From: David Miller <davem@davemloft.net>
To: eilong@broadcom.com
Cc: sgruszka@redhat.com, netdev@vger.kernel.org, vladz@broadcom.com,
mchan@broadcom.com
Subject: Re: [PATCH 2/4] bnx2x: remove not necessary compiler barrier
Date: Mon, 15 Mar 2010 15:47:29 -0700 (PDT) [thread overview]
Message-ID: <20100315.154729.41966662.davem@davemloft.net> (raw)
In-Reply-To: <1268236857.30985.2.camel@lb-tlvb-eilong.il.broadcom.com>
From: "Eilon Greenstein" <eilong@broadcom.com>
Date: Wed, 10 Mar 2010 18:00:57 +0200
> On Tue, 2010-03-09 at 08:55 -0800, Stanislaw Gruszka wrote:
>> Access to fp->tx_bd_prod is protected by __netif_tx_lock, so we do not
>> need any barrier for that.
>>
>> Update of fp->tx_bd_cons in bnx2x_tx_int() is not protected by lock, but
>> barrier() nor smb_mb() in bnx2x_tx_avail() not guarantee we will see
>> values that is written on other cpu. Ordering issues between
>> netif_tx_stop_queue(), netif_tx_queue_stopped(), fp->tx_bd_cons = bd_cons
>> and bnx2x_tx_avail() are already handled by smp_mb() in bnx2x_tx_int()
>> and bnx2x_start_xmit().
>>
>> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Applied.
next prev parent reply other threads:[~2010-03-15 22:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 16:55 [PATCH 1/4] bnx2x: use smp_mb() to keep ordering of read write operations Stanislaw Gruszka
2010-03-09 16:55 ` [PATCH 2/4] bnx2x: remove not necessary compiler barrier Stanislaw Gruszka
2010-03-09 16:55 ` [PATCH 3/4] bnx2x: change smp_mb() comment to conform the true Stanislaw Gruszka
2010-03-09 16:55 ` [PATCH 4/4] bnx2x: merge common code when stopping queue Stanislaw Gruszka
2010-03-10 16:02 ` Eilon Greenstein
2010-03-10 16:01 ` [PATCH 3/4] bnx2x: change smp_mb() comment to conform the true Eilon Greenstein
2010-03-15 22:47 ` David Miller
2010-03-10 16:00 ` [PATCH 2/4] bnx2x: remove not necessary compiler barrier Eilon Greenstein
2010-03-15 22:47 ` David Miller [this message]
2010-03-10 15:59 ` [PATCH 1/4] bnx2x: use smp_mb() to keep ordering of read write operations Eilon Greenstein
2010-03-15 22:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100315.154729.41966662.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
--cc=vladz@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).