From: David Miller <davem@davemloft.net>
To: cooldavid@cooldavid.org
Cc: chavey@google.com, ethanhsiao@jmicron.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2.6.33 2/2] jme: Adding lock to protect vlgrp structure.
Date: Mon, 15 Mar 2010 15:53:50 -0700 (PDT) [thread overview]
Message-ID: <20100315.155350.26952440.davem@davemloft.net> (raw)
In-Reply-To: <20100315191339.M2560@cooldavid.org>
From: "Guo-Fu Tseng" <cooldavid@cooldavid.org>
Date: Tue, 16 Mar 2010 03:13:33 +0800
> The vlan_rx_register is called through ioctl.
> And the packet feeding is called in the tasklet.
> I see no lock in register_vlan_dev(), register_vlan_device(), and vlan_ioctl_handler()
> which is related to the vlan_hwaccel_receive_skb(), vlan_hwaccel_rx().
>
> It prevents the vlgrp pointer be modified while trying to feed the packet.
This is not how you fix this. Adding a new lock to your hot code
path of packet receiving is the last thing you should be doing.
Instead, do what other drivers do, take down the device and bring it
back up again when changing the ->vlgrp pointer.
See drivers/net/tg3.c:tg3_vlan_rx_register() for an example.
next prev parent reply other threads:[~2010-03-15 22:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-15 5:15 [PATCH v2.6.33 1/2] jme: Fix VLAN memory leak cooldavid
2010-03-15 5:15 ` [PATCH v2.6.33 2/2] jme: Adding lock to protect vlgrp structure cooldavid
2010-03-15 18:22 ` Laurent Chavey
2010-03-15 19:13 ` Guo-Fu Tseng
2010-03-15 22:53 ` David Miller [this message]
2010-03-16 7:15 ` Guo-Fu Tseng
2010-03-16 7:40 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100315.155350.26952440.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chavey@google.com \
--cc=cooldavid@cooldavid.org \
--cc=ethanhsiao@jmicron.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).