From: David Miller <davem@davemloft.net>
To: keil@b1-systems.de
Cc: torvalds@linux-foundation.org, lars.ellenberg@linbit.com,
netdev@vger.kernel.org, andreas@eversberg.eu,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ISDN: Add PCI ID for HFC-2S/4S Beronet Card PCIe
Date: Mon, 15 Mar 2010 16:01:33 -0700 (PDT) [thread overview]
Message-ID: <20100315.160133.67908104.davem@davemloft.net> (raw)
In-Reply-To: <1268668176.12629@pingi>
From: Karsten Keil <keil@b1-systems.de>
Date: Mon, 15 Mar 2010 14:18:41 +0100
> A few subdevice IDs seem to have been dropped when hfc_multi was
> included upstream, just compare the list at
> http://www.openvox.cn/viewvc/misdn/trunk/hfc_multi.c?revision=75&view=annotate#l175
> with the IDs in drivers/isdn/hardware/mISDN/hfcmulti.c
>
> Added PCIe 2 Port card and LED settings (same as PCI) /KKe
>
> Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
> Signed-off-by: Karsten Keil <keil@b1-systems.de>
We don't add new defines to linux/pci_ids.h, it is deprecated.
Simply add the device ID constants to the table.
The only exception is the case where a device ID is used in
more than one driver, but even that scenerio is heavily
discouraged.
next prev parent reply other threads:[~2010-03-15 23:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-15 13:18 [PATCH] ISDN: Add PCI ID for HFC-2S/4S Beronet Card PCIe Karsten Keil
2010-03-15 13:18 ` [PATCH V2] " Karsten Keil
2010-03-16 2:09 ` David Miller
2010-03-15 23:01 ` David Miller [this message]
2010-03-16 1:08 ` [PATCH] " Karsten Keil
2010-03-16 2:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100315.160133.67908104.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=andreas@eversberg.eu \
--cc=keil@b1-systems.de \
--cc=lars.ellenberg@linbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).