* [patch] myri: remove dead code
@ 2010-03-15 8:24 Dan Carpenter
2010-03-15 11:19 ` Andrew Gallatin
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2010-03-15 8:24 UTC (permalink / raw)
To: Andrew Gallatin
Cc: Brice Goglin, David S. Miller, Patrick McHardy, netdev,
kernel-janitors
We can never reach the return statement.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/net/myri10ge/myri10ge.c b/drivers/net/myri10ge/myri10ge.c
index 676c513..e84dd3e 100644
--- a/drivers/net/myri10ge/myri10ge.c
+++ b/drivers/net/myri10ge/myri10ge.c
@@ -3687,7 +3687,6 @@ static void myri10ge_probe_slices(struct myri10ge_priv *mgp)
if (status != 0) {
dev_err(&mgp->pdev->dev, "failed reset\n");
goto abort_with_fw;
- return;
}
mgp->max_intr_slots = cmd.data0 / sizeof(struct mcp_slot);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] myri: remove dead code
2010-03-15 8:24 [patch] myri: remove dead code Dan Carpenter
@ 2010-03-15 11:19 ` Andrew Gallatin
2010-03-15 23:06 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Gallatin @ 2010-03-15 11:19 UTC (permalink / raw)
To: Dan Carpenter
Cc: Brice Goglin, David S. Miller, Patrick McHardy, netdev,
kernel-janitors
Dan Carpenter wrote:
> We can never reach the return statement.
Agreed, thanks for pointing that out.
Drew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] myri: remove dead code
2010-03-15 11:19 ` Andrew Gallatin
@ 2010-03-15 23:06 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2010-03-15 23:06 UTC (permalink / raw)
To: gallatin; +Cc: error27, brice, kaber, netdev, kernel-janitors
From: Andrew Gallatin <gallatin@myri.com>
Date: Mon, 15 Mar 2010 07:19:26 -0400
> Dan Carpenter wrote:
>> We can never reach the return statement.
>
> Agreed, thanks for pointing that out.
Applied, thanks everyone.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-03-15 23:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-15 8:24 [patch] myri: remove dead code Dan Carpenter
2010-03-15 11:19 ` Andrew Gallatin
2010-03-15 23:06 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).