From: David Miller <davem@davemloft.net>
To: gerrit@erg.abdn.ac.uk
Cc: acme@redhat.com, netdev@vger.kernel.org, dccp@vger.kernel.org
Subject: Re: net-2.6 [Bug-Fix][dccp]: fix oops caused after failed initialisation
Date: Mon, 15 Mar 2010 16:07:04 -0700 (PDT) [thread overview]
Message-ID: <20100315.160704.112076366.davem@davemloft.net> (raw)
In-Reply-To: <20100315061318.GA6110@gerrit.erg.abdn.ac.uk>
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Date: Mon, 15 Mar 2010 07:13:19 +0100
> dccp: fix panic caused by failed initialisation
>
> This fixes a kernel panic reported thanks to Andre Noll:
>
> if DCCP is compiled into the kernel and any out of the initialisation
> steps in net/dccp/proto.c:dccp_init() fail, a subsequent attempt to create
> a SOCK_DCCP socket will panic, since inet{,6}_create() are not prevented
> from creating DCCP sockets.
>
> This patch fixes the problem by propagating a failure in dccp_init() to
> dccp_v{4,6}_init_net(), and from there to dccp_v{4,6}_init(), so that the
> DCCP protocol is not made available if its initialisation fails.
>
> Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Applied, thanks Gerrit.
prev parent reply other threads:[~2010-03-15 23:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-15 6:13 net-2.6 [Bug-Fix][dccp]: fix oops caused after failed initialisation Gerrit Renker
2010-03-15 23:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100315.160704.112076366.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=acme@redhat.com \
--cc=dccp@vger.kernel.org \
--cc=gerrit@erg.abdn.ac.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).