Re: [PATCH] NET: tg3: fix brace, switch, and comma spacing coding style in tg3.c This is a patch to the tg3.c file that aligns switch and case statements, else statements following braces, and inserts a space after commas listed in the coding style g

Re: [PATCH] NET: tg3: fix brace, switch, and comma spacing coding style in tg3.c This is a patch to the tg3.c file that aligns switch and case statements, else statements following braces, and inserts a space after commas listed in the coding style g

[Steven Harms]

David,

Would you like me to submit the patch adding only the spaces after
commas and leave the rest of the defines as is, or discard the changes
all together?

On Sat, Mar 13, 2010 at 2:49 PM, David Miller <davem@davemloft.net> wrote:
> From: Steven Harms <sjharms@gmail.com>
> Date: Sat, 13 Mar 2010 14:39:11 -0500
>
>> -#define tw32_mailbox(reg, val)       tp->write32_mbox(tp, reg, val)
>> -#define tw32_mailbox_f(reg, val)     tw32_mailbox_flush(tp, (reg), (val))
>> -#define tw32_rx_mbox(reg, val)       tp->write32_rx_mbox(tp, reg, val)
>> -#define tw32_tx_mbox(reg, val)       tp->write32_tx_mbox(tp, reg, val)
>> -#define tr32_mailbox(reg)    tp->read32_mbox(tp, reg)
>> +#define tw32_mailbox(reg, val)       (tp->write32_mbox(tp, reg, val))
>
> Please keep this kind of code masterbation to yourself.
> This is not the style we want for this driver.
>



-- 
GPG Key ID: C92EF367 / 1428 FE8E 1E07 DDA8 EFD7 195F DCCD F5B3 C92E F367

WWW: http://www.sharms.org/blog

Re: [PATCH] NET: tg3: fix brace, switch, and comma spacing coding style in tg3.c This is a patch to the tg3.c file that aligns switch and case statements, else statements following braces, and inserts a space after commas listed in the coding style g

[David Miller]

From: Steven Harms <thisdyingdream@gmail.com>
Date: Sat, 13 Mar 2010 14:52:26 -0500

> Would you like me to submit the patch adding only the spaces after
> commas and leave the rest of the defines as is, or discard the changes
> all together?

I would like you to toss them altogether.

Re: [PATCH] NET: tg3: fix brace, switch, and comma spacing coding style in tg3.c This is a patch to the tg3.c file that aligns switch and case statements, else statements following braces, and inserts a space after commas listed in the coding style g

[Joe Perches]

On Sat, 2010-03-13 at 11:55 -0800, David Miller wrote:
> From: Steven Harms <thisdyingdream@gmail.com>
> Date: Sat, 13 Mar 2010 14:52:26 -0500
> 
> > Would you like me to submit the patch adding only the spaces after
> > commas and leave the rest of the defines as is, or discard the changes
> > all together?
> 
> I would like you to toss them altogether.

I think that Steven got off on the wrong foot
a bit by adding the parentheses to the defines.

I think the other changes he suggested are
tree-wide style consistency only and are ok.

Perhaps you might reconsider later, after
net-next reopens.

Re: [PATCH] NET: tg3: fix brace, switch, and comma spacing coding style in tg3.c This is a patch to the tg3.c file that aligns switch and case statements, else statements following braces, and inserts a space after commas listed in the coding style g

[Matt Carlson]

I have a patch awaiting net-next that does these kinds of things.  I
can roll (most of) Steven's changes into that patch and get it all
done in one shot if you like.

On Sat, Mar 13, 2010 at 12:22:22PM -0800, Joe Perches wrote:
> On Sat, 2010-03-13 at 11:55 -0800, David Miller wrote:
> > From: Steven Harms <thisdyingdream@gmail.com>
> > Date: Sat, 13 Mar 2010 14:52:26 -0500
> > 
> > > Would you like me to submit the patch adding only the spaces after
> > > commas and leave the rest of the defines as is, or discard the changes
> > > all together?
> > 
> > I would like you to toss them altogether.
> 
> I think that Steven got off on the wrong foot
> a bit by adding the parentheses to the defines.
> 
> I think the other changes he suggested are
> tree-wide style consistency only and are ok.
> 
> Perhaps you might reconsider later, after
> net-next reopens.
> 
> 
>