From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Matt Carlson" Subject: Re: [PATCH] NET: tg3: fix brace, switch, and comma spacing coding style in tg3.c This is a patch to the tg3.c file that aligns switch and case statements, else statements following braces, and inserts a space after commas listed in the coding style g Date: Mon, 15 Mar 2010 11:39:26 -0700 Message-ID: <20100315183926.GA9159@xw6200.broadcom.net> References: <20100313.115555.209991546.davem@davemloft.net> <1268511742.30289.74.camel@Joe-Laptop.home> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: "David Miller" , "thisdyingdream@gmail.com" , "sjharms@gmail.com" , "Matthew Carlson" , "Michael Chan" , "Benjamin Li" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "sharms@ubuntu.com" To: "Joe Perches" Return-path: Received: from mms2.broadcom.com ([216.31.210.18]:4518 "EHLO mms2.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752640Ab0COSjh (ORCPT ); Mon, 15 Mar 2010 14:39:37 -0400 In-Reply-To: <1268511742.30289.74.camel@Joe-Laptop.home> Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: I have a patch awaiting net-next that does these kinds of things. I can roll (most of) Steven's changes into that patch and get it all done in one shot if you like. On Sat, Mar 13, 2010 at 12:22:22PM -0800, Joe Perches wrote: > On Sat, 2010-03-13 at 11:55 -0800, David Miller wrote: > > From: Steven Harms > > Date: Sat, 13 Mar 2010 14:52:26 -0500 > > > > > Would you like me to submit the patch adding only the spaces after > > > commas and leave the rest of the defines as is, or discard the changes > > > all together? > > > > I would like you to toss them altogether. > > I think that Steven got off on the wrong foot > a bit by adding the parentheses to the defines. > > I think the other changes he suggested are > tree-wide style consistency only and are ok. > > Perhaps you might reconsider later, after > net-next reopens. > > >