netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org
Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org,
	oliver.hartkopp-l29pVbxQd1IUtdQbppsyvg@public.gmane.org,
	urs.thuermann-l29pVbxQd1IUtdQbppsyvg@public.gmane.org
Subject: Re: [PATCH] can: bfin_can: switch to common Blackfin can header
Date: Tue, 16 Mar 2010 21:28:30 -0700 (PDT)	[thread overview]
Message-ID: <20100316.212830.50212878.davem@davemloft.net> (raw)
In-Reply-To: <1268150589-27123-1-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>

From: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
Date: Tue,  9 Mar 2010 11:03:09 -0500

> The MMR bits are being moved to this header, so include it.
> 
> Signed-off-by: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>

I can't actually apply this since this asm/bfin_can.h header
doesn't even exist in the tree yet so this change will
break the build.

This doesn't make any sense at all, it's impossible to
prevent breaking the build unless you add the asm/bfin_can.h
header at the same time you do these changes.

Why not submit those two things together as one commit
instead?

Thanks.

  parent reply	other threads:[~2010-03-17  4:28 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-09 16:03 [PATCH] can: bfin_can: switch to common Blackfin can header Mike Frysinger
     [not found] ` <1268150589-27123-1-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2010-03-10  7:41   ` Wolfgang Grandegger
2010-03-10 12:17     ` [Uclinux-dist-devel] " Mike Frysinger
     [not found]       ` <8bd0f97a1003100417x6e9830dav949fd6b0511d99d0-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-03-10 15:35         ` David Miller
2010-03-17  4:28   ` David Miller [this message]
     [not found]     ` <20100316.212830.50212878.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-03-17  4:45       ` [Uclinux-dist-devel] " Mike Frysinger
     [not found]         ` <8bd0f97a1003162145i77f65158ne255b28239e1b595-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-03-17  5:02           ` David Miller
     [not found]             ` <20100316.220232.170244945.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-03-17  5:25               ` Mike Frysinger
     [not found]                 ` <8bd0f97a1003162225i439d9900mfdc03eca5de0ff6e-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-03-17  5:51                   ` David Miller
     [not found]                     ` <20100316.225150.213941689.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-03-19  6:35                       ` Mike Frysinger
2010-03-19  6:56                         ` AW: " Hartkopp, Oliver (K-EFFI/P)
     [not found]                           ` <26B4E6A46012A1469B4EB3BC2A7CAAEC44EF47-2ISBvSz7ubqzqAecw3LaLo+MsED4In1V@public.gmane.org>
2010-03-19 16:23                             ` Mike Frysinger
2010-03-22  3:39                         ` David Miller
2010-03-22  3:54                           ` Mike Frysinger
2010-03-22  3:58                             ` David Miller
2010-03-22  7:04                               ` Mike Frysinger
2010-03-22 17:17                                 ` David Miller
2010-03-22 21:09                                   ` Mike Frysinger
2010-03-22 23:36                                     ` David Miller
2010-03-23  1:42                                       ` Mike Frysinger
     [not found]                                         ` <8bd0f97a1003221842k4e44bfccmfc7858b9c793b44f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-03-23  1:48                                           ` David Miller
2010-03-23  1:50                                             ` [Uclinux-dist-devel] " Mike Frysinger
2010-03-23  1:57                                               ` David Miller
2010-03-23  3:53                                                 ` Mike Frysinger
2010-03-22  7:06 ` Mike Frysinger
     [not found]   ` <1269241561-28956-1-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2010-03-23  3:06     ` David Miller
2010-03-23  3:53       ` [Uclinux-dist-devel] " Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100316.212830.50212878.davem@davemloft.net \
    --to=davem-ft/pcqaiutieiz0/mpfg9q@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=oliver.hartkopp-l29pVbxQd1IUtdQbppsyvg@public.gmane.org \
    --cc=socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org \
    --cc=uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org \
    --cc=urs.thuermann-l29pVbxQd1IUtdQbppsyvg@public.gmane.org \
    --cc=vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).