From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] can: bfin_can: switch to common Blackfin can header Date: Tue, 16 Mar 2010 21:28:30 -0700 (PDT) Message-ID: <20100316.212830.50212878.davem@davemloft.net> References: <1268150589-27123-1-git-send-email-vapier@gentoo.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org, oliver.hartkopp-l29pVbxQd1IUtdQbppsyvg@public.gmane.org, urs.thuermann-l29pVbxQd1IUtdQbppsyvg@public.gmane.org To: vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org Return-path: In-Reply-To: <1268150589-27123-1-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org From: Mike Frysinger Date: Tue, 9 Mar 2010 11:03:09 -0500 > The MMR bits are being moved to this header, so include it. > > Signed-off-by: Mike Frysinger I can't actually apply this since this asm/bfin_can.h header doesn't even exist in the tree yet so this change will break the build. This doesn't make any sense at all, it's impossible to prevent breaking the build unless you add the asm/bfin_can.h header at the same time you do these changes. Why not submit those two things together as one commit instead? Thanks.