From: David Miller <davem@davemloft.net>
To: amwang@redhat.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [Patch] netpoll: allow spaces in its parameter
Date: Tue, 16 Mar 2010 23:14:34 -0700 (PDT) [thread overview]
Message-ID: <20100316.231434.177653499.davem@davemloft.net> (raw)
In-Reply-To: <4BA071BD.5040900@redhat.com>
From: Cong Wang <amwang@redhat.com>
Date: Wed, 17 Mar 2010 14:07:57 +0800
> No, but silently accepting it as 0 is not correct, why don't
> reject it if it is not allowed?
You have to be careful even with that. For example, if two
netconsoles are specified, seeing the space shouldn't
kill the first netconsole specification we parsed.
A warning perhaps, but outright rejection of all specifications is
really bad behavior.
next prev parent reply other threads:[~2010-03-17 6:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 5:53 [Patch] netpoll: allow spaces in its parameter Amerigo Wang
2010-03-17 5:54 ` David Miller
2010-03-17 6:01 ` Cong Wang
2010-03-17 5:59 ` David Miller
2010-03-17 6:07 ` Cong Wang
2010-03-17 6:14 ` David Miller [this message]
2010-03-17 6:38 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100316.231434.177653499.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amwang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).