From mboxrd@z Thu Jan 1 00:00:00 1970 From: Karsten Keil Subject: Re: [PATCH] ISDN: Add PCI ID for HFC-2S/4S Beronet Card PCIe Date: Tue, 16 Mar 2010 02:08:57 +0100 Message-ID: <201003160208.57232.keil@b1-systems.de> References: <1268668176.12629@pingi> <20100315.160133.67908104.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: torvalds@linux-foundation.org, lars.ellenberg@linbit.com, netdev@vger.kernel.org, andreas@eversberg.eu, akpm@linux-foundation.org, linux-kernel@vger.kernel.org To: David Miller Return-path: Received: from d112a2.x-mailer.de ([212.162.53.4]:45998 "EHLO d112a2.x-mailer.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937290Ab0CPBI7 convert rfc822-to-8bit (ORCPT ); Mon, 15 Mar 2010 21:08:59 -0400 In-Reply-To: <20100315.160133.67908104.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Dienstag, 16. M=E4rz 2010 00:01:33 David Miller wrote: > From: Karsten Keil > Date: Mon, 15 Mar 2010 14:18:41 +0100 >=20 > > A few subdevice IDs seem to have been dropped when hfc_multi was > > included upstream, just compare the list at > > http://www.openvox.cn/viewvc/misdn/trunk/hfc_multi.c?revision=3D75&= view=3Dann > >otate#l175 with the IDs in drivers/isdn/hardware/mISDN/hfcmulti.c > > > > Added PCIe 2 Port card and LED settings (same as PCI) /KKe > > > > Signed-off-by: Lars Ellenberg > > Signed-off-by: Karsten Keil >=20 > We don't add new defines to linux/pci_ids.h, it is deprecated. > Simply add the device ID constants to the table. Good policy, makes sense. Will send a new version. May a check for adding defines to would help to enfor= ce it. >=20 > The only exception is the case where a device ID is used in > more than one driver, but even that scenerio is heavily > discouraged. >=20 Is here some plan to cleanup drivers for -next and remove IDs from pci_= ids.h, or should it not changed for old entries ? Karsten