From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: locking issue in vhost_net_set_backend
Date: Tue, 16 Mar 2010 16:48:24 +0200 [thread overview]
Message-ID: <20100316144824.GA12793@redhat.com> (raw)
In-Reply-To: <4B9F8F4F.7010103@gmail.com>
On Tue, Mar 16, 2010 at 03:01:51PM +0100, Jiri Slaby wrote:
> On 03/16/2010 02:58 PM, Jiri Slaby wrote:
>> I don't see how the lock is unlocked on the error paths and as it is not
>> on none of the them maybe I'm missing something?
>
> And there is one more issue in vhost_set_vring, several returns from
> VHOST_SET_VRING_KICK, VHOST_SET_VRING_CALL, VHOST_SET_VRING_ERR with the
> vq->mutex held.
Thanks!
I have patches for these that I'll push out shortly.
> --
> js
next prev parent reply other threads:[~2010-03-16 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 13:58 locking issue in vhost_net_set_backend Jiri Slaby
2010-03-16 14:01 ` Jiri Slaby
2010-03-16 14:48 ` Michael S. Tsirkin [this message]
2010-03-16 16:11 ` Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100316144824.GA12793@redhat.com \
--to=mst@redhat.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).