From: Vitaliy Gusev <vgusev@openvz.org>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <dada1@cosmosbay.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
netdev@vger.kernel.org
Subject: Re: [PATCH] route: Fix caught BUG_ON during rt_secret_rebuild_oneshot()
Date: Tue, 16 Mar 2010 18:27:08 +0300 [thread overview]
Message-ID: <201003161827.08595.vgusev@openvz.org> (raw)
In-Reply-To: <20100316143437.GA8225@hmsreliant.think-freely.org>
On Tuesday 16 March 2010 05:34:37 pm Neil Horman wrote:
...
> Yeah, this seems reasonable. Although this might be a good time to bring up the
> subject of deprecating or removing the secret interval. We've had our
> statistical analysis bits in place to drive the rebuilding of the cache in the
> event that any one chain gets too long, and in the year or so that we've had it,
> it seems we've shaken out a few bugs with it (which suggests that people are
> using it routinely). As such, might it be time to just drop the rebuild timer
> in its entirety?
Rebuild timer was introduced by secure reason when there was no analysis for
chain lenght. Now it seems that rebuild timer can be removed.
>
> Until that decision is made of course, the above seems like a sane fix for it.
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
>
>
Thanks,
Vitaliy Gusev
next prev parent reply other threads:[~2010-03-16 15:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 11:07 [PATCH] route: Fix caught BUG_ON during rt_secret_rebuild_oneshot() Vitaliy Gusev
2010-03-16 14:34 ` Neil Horman
2010-03-16 15:27 ` Vitaliy Gusev [this message]
2010-03-16 17:35 ` Neil Horman
2010-03-16 18:08 ` Eric Dumazet
2010-03-16 18:18 ` Neil Horman
2010-03-16 21:30 ` David Miller
2010-03-17 0:54 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003161827.08595.vgusev@openvz.org \
--to=vgusev@openvz.org \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).