From: David Miller <davem@davemloft.net>
To: chase.douglas@canonical.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] 3c59x: Acquire vortex lock instead of disabling irq
Date: Wed, 17 Mar 2010 11:47:17 -0700 (PDT) [thread overview]
Message-ID: <20100317.114717.30960972.davem@davemloft.net> (raw)
In-Reply-To: <40ec3ea41003171144s6acbf2fdl4434f2147b8244a0@mail.gmail.com>
From: Chase Douglas <chase.douglas@canonical.com>
Date: Wed, 17 Mar 2010 14:44:30 -0400
> On Wed, Mar 17, 2010 at 2:27 PM, David Miller <davem@davemloft.net> wrote:
>> From: Chase Douglas <chase.douglas@canonical.com>
>> Date: Wed, 17 Mar 2010 14:20:45 -0400
>>
>>> If that's the case, what's the solution? It's not safe to call
>>> disable_irq* in softirq context anymore.
>>
>> That's a huge problem, because such a restriction has broken
>> several drivers. 3c59x is not the only one which uses this
>> technique for this reason. The 8390 one does too.
>
> So basically the answer right now is: it's broken and needs to be
> reworked, and a switch to disabling irqs is deemed inadequate. Is that
> accurate?
Yep. The bug is whatever caused disable_irq*() to stop working
where these drivers have been using it for what feels like
a century :-)
prev parent reply other threads:[~2010-03-17 18:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 14:33 [PATCH 0/1] 3c59x: Acquire vortex lock instead of disabling irq Chase Douglas
2010-03-17 14:33 ` [PATCH 1/1] " Chase Douglas
2010-03-17 18:03 ` David Miller
2010-03-17 18:20 ` Chase Douglas
2010-03-17 18:27 ` David Miller
2010-03-17 18:44 ` Chase Douglas
2010-03-17 18:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100317.114717.30960972.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chase.douglas@canonical.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).