From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergey Senozhatsky Subject: Re: [PATCH] r8169: Fix rtl8169_rx_interrupt() Date: Wed, 17 Mar 2010 12:58:56 +0200 Message-ID: <20100317105856.GB3322@swordfish> References: <1268686865.2824.4.camel@edumazet-laptop> <1268699602.2824.14.camel@edumazet-laptop> <20100316145914.GB3332@swordfish.minsk.epam.com> <1268751933.3094.45.camel@edumazet-laptop> <20100316151023.GC3332@swordfish.minsk.epam.com> <1268752826.3094.48.camel@edumazet-laptop> <20100316182619.GA3451@swordfish> <1268765284.2932.17.camel@edumazet-laptop> <20100317072539.GA3579@swordfish> <1268811437.2932.66.camel@edumazet-laptop> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GID0FwUMdk1T2AWN" Cc: Oleg Nesterov , David Miller , Francois Romieu , netdev@vger.kernel.org To: Eric Dumazet Return-path: Received: from mail-yw0-f201.google.com ([209.85.211.201]:39337 "EHLO mail-yw0-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754116Ab0CQK6J (ORCPT ); Wed, 17 Mar 2010 06:58:09 -0400 Received: by ywh39 with SMTP id 39so352104ywh.21 for ; Wed, 17 Mar 2010 03:58:08 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1268811437.2932.66.camel@edumazet-laptop> Sender: netdev-owner@vger.kernel.org List-ID: --GID0FwUMdk1T2AWN Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, We did pktgen over LAN testing for several hours: iftop 19.1Mb 38.1Mb 57.2M= b 76.3Mb 95.4Mb =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=B4=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=B4=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=B4=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=B4=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80 xxxxxxxx0007t2 =3D> xxxxxxxxxxxxxx.xxxxx.xxxx= =2Exxx 0b 3.60Kb 4.28Kb <=3D = 92.7Mb 92.7Mb 92.5Mb =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80 TX: cumm: 2.50MB peak: 57.7Kb = rates: 7.71Kb 5.97Kb 10.7Kb RX: 28.0GB 92.9Mb = 92.7Mb 92.8Mb 92.6Mb TOTAL: 28.0GB 92.9Mb = 92.7Mb 92.8Mb 92.6M Without any problems. As soon as I switched back to localhost "pollution": [ 7343.999279] ------------[ cut here ]------------ [ 7343.999292] WARNING: at net/sched/sch_generic.c:255 dev_watchdog+0xc1/0x= 125() [ 7343.999295] Hardware name: F3JC =20 [ 7343.999298] NETDEV WATCHDOG: eth0 (r8169): transmit queue 0 timed out [ 7343.999301] Modules linked in: pktgen ppp_async crc_ccitt ipv6 ppp_gener= ic slhc snd_hwdep snd_hda_codec_si3054 snd_hda_codec_realtek sdhci_pci sdhc= i snd_hda_intel mmc_core asus_laptop sparse_keymap snd_hda_codec led_class snd_pcm rng_core sg psmou= se snd_timer snd_page_alloc i2c_i801 evdev snd soundcore serio_raw r8169 mi= i usbhid hid uhci_hcd ehci_hcd sr_mod cdrom sd_mod usbcore ata_piix [ 7343.999361] Pid: 4801, comm: kpktgend_0 Tainted: G W 2.6.34-rc1-= dbg-git6-r8169 #47 [ 7343.999364] Call Trace: [ 7343.999372] [] warn_slowpath_common+0x65/0x7c [ 7343.999378] [] ? dev_watchdog+0xc1/0x125 [ 7343.999383] [] warn_slowpath_fmt+0x24/0x27 [ 7343.999388] [] dev_watchdog+0xc1/0x125 [ 7343.999395] [] ? run_timer_softirq+0x120/0x1eb [ 7343.999401] [] run_timer_softirq+0x176/0x1eb [ 7343.999406] [] ? run_timer_softirq+0x120/0x1eb [ 7343.999411] [] ? dev_watchdog+0x0/0x125 [ 7343.999417] [] __do_softirq+0x8d/0x117 [ 7343.999422] [] do_softirq+0x2b/0x43 [ 7343.999426] [] irq_exit+0x38/0x75 [ 7343.999433] [] smp_apic_timer_interrupt+0x66/0x74 [ 7343.999438] [] apic_timer_interrupt+0x36/0x3c [ 7343.999447] [] ? pktgen_thread_worker+0x5c4/0x631 [pktgen] [ 7343.999454] [] ? autoremove_wake_function+0x0/0x2f [ 7343.999459] [] ? autoremove_wake_function+0x0/0x2f [ 7343.999465] [] ? pktgen_thread_worker+0x0/0x631 [pktgen] [ 7343.999470] [] kthread+0x6a/0x6f [ 7343.999476] [] ? kthread+0x0/0x6f [ 7343.999481] [] kernel_thread_helper+0x6/0x1a [ 7343.999485] ---[ end trace a22d306b065d4a68 ]--- [ 7344.012654] r8169 0000:02:00.0: eth0: link up [ 7356.012657] r8169 0000:02:00.0: eth0: link up [ 7368.013545] r8169 0000:02:00.0: eth0: link up Sergey On (03/17/10 08:37), Eric Dumazet wrote: > trimming some cc >=20 > Le mercredi 17 mars 2010 =C3=A0 09:25 +0200, Sergey Senozhatsky a =C3=A9c= rit : > > Hello, > >=20 > > cumulative patch: > >=20 > > [ 155.337373] ------------[ cut here ]------------ > > [ 155.337386] WARNING: at net/sched/sch_generic.c:255 dev_watchdog+0xc= 1/0x125() > > [ 155.337390] Hardware name: F3JC =20 > > [ 155.337394] NETDEV WATCHDOG: eth0 (r8169): transmit queue 0 timed out > > [ 155.337397] Modules linked in: pktgen ppp_async crc_ccitt ipv6 ppp_g= eneric slhc snd_hwdep snd_hda_codec_si3054 snd_hda_codec_realtek sdhci_pci = sdhci snd_hda_intel snd_hda_codec > > asus_laptop sparse_keymap mmc_core led_class snd_pcm snd_timer snd_page= _alloc psmouse rng_core snd soundcore sg i2c_i801 evdev serio_raw r8169 mii= usbhid hid uhci_hcd ehci_hcd > > sr_mod cdrom sd_mod usbcore ata_piix > > [ 155.337468] Pid: 7, comm: ksoftirqd/1 Tainted: G W 2.6.34-rc= 1-dbg-git6-r8169 #47 > > [ 155.337472] Call Trace: > > [ 155.337481] [] warn_slowpath_common+0x65/0x7c > > [ 155.337506] [] ? dev_watchdog+0xc1/0x125 > > [ 155.337512] [] warn_slowpath_fmt+0x24/0x27 > > [ 155.337517] [] dev_watchdog+0xc1/0x125 > > [ 155.337525] [] ? run_timer_softirq+0x120/0x1eb > > [ 155.337530] [] run_timer_softirq+0x176/0x1eb > > [ 155.337536] [] ? run_timer_softirq+0x120/0x1eb > > [ 155.337566] [] ? dev_watchdog+0x0/0x125 > > [ 155.337576] [] __do_softirq+0x8d/0x117 > > [ 155.337667] [] do_softirq+0x2b/0x43 > > [ 155.337729] [] run_ksoftirqd+0x71/0x140 > > [ 155.337745] [] ? run_ksoftirqd+0x0/0x140 > > [ 155.337810] [] kthread+0x6a/0x6f > > [ 155.337832] [] ? kthread+0x0/0x6f > > [ 155.337903] [] kernel_thread_helper+0x6/0x1a > > [ 155.337907] ---[ end trace a22d306b065d4a68 ]--- > > [ 155.350902] r8169 0000:02:00.0: eth0: link up > > [ 167.350892] r8169 0000:02:00.0: eth0: link up > >=20 > >=20 > >=20 >=20 > On receiver ? >=20 > I suspect lot of work is needed on this driver to make it working, but I > dont have a machine with said adapter. >=20 > Are you in 100 Mb full duplex mode ? >=20 >=20 --GID0FwUMdk1T2AWN Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iJwEAQECAAYFAkugtfAACgkQfKHnntdSXjTSFwP9GPuFRn2h48og28ASq2+f2dXX X3sc6UBBp2/QySlBiZd3TnGe1SHrwLIB5kRRD22qib3jCYPG0TA+i8SAi83X1yQW JFiAoNKrw79xrGahLnNyY9uH08k7r1DcBnLXRd8MaGzZ8kj58N5Xp2TzonCfAJkt duviiV8asbtoriBMf0w= =VXaE -----END PGP SIGNATURE----- --GID0FwUMdk1T2AWN--