From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: David Miller <davem@davemloft.net>,
"Tantilov, Emil S" <emil.s.tantilov@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Allan, Bruce W" <bruce.w.allan@intel.com>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>
Subject: Re: e1000e: Fix build with CONFIG_PM disabled.
Date: Thu, 18 Mar 2010 00:51:22 +0100 [thread overview]
Message-ID: <201003180051.23075.rjw@sisk.pl> (raw)
In-Reply-To: <1268869036.19191.92.camel@jbrandeb-mobl3.amr.corp.intel.com>
On Thursday 18 March 2010, Jesse Brandeburg wrote:
> On Wed, 2010-03-17 at 15:39 -0700, Rafael J. Wysocki wrote:
> > On Wednesday 17 March 2010, David Miller wrote:
> > > From: "Tantilov, Emil S" <emil.s.tantilov@intel.com>
> > > Date: Wed, 17 Mar 2010 11:57:59 -0600
> > >
> > > > But then the driver build fails again when CONFIG_PM_RUNTIME is not set.
> > > >
> > > > drivers/net/e1000e/netdev.c: In function `e1000_runtime_resume`:
> > > > drivers/net/e1000e/netdev.c:4807: error: `struct dev_pm_info` has no member named `runtime_auto`
> > >
> > > Ugh, can someone send me a fix for that?
> >
> > Appended, on top of your patch. It only moves the code around and adds
> > #ifdefs.
>
> I know this is throwing a wrench in things, but won't this series of
> changes break a clean bisect (due to the compile errors?)
Well, it will, but reverting them doesn't actually help fix bisectability.
You'd have to "git reset --hard" to the commit preceding them and then apply
the combo patch.
Rafael
next prev parent reply other threads:[~2010-03-17 23:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 6:41 e1000e: Fix build with CONFIG_PM disabled David Miller
2010-03-17 17:57 ` Tantilov, Emil S
2010-03-17 18:17 ` David Miller
2010-03-17 20:34 ` Rafael J. Wysocki
2010-03-17 22:39 ` Rafael J. Wysocki
2010-03-17 23:37 ` Jesse Brandeburg
2010-03-17 23:51 ` Rafael J. Wysocki [this message]
2010-03-18 6:11 ` David Miller
2010-03-18 6:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003180051.23075.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=bruce.w.allan@intel.com \
--cc=davem@davemloft.net \
--cc=emil.s.tantilov@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).