From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com, gregory.v.rose@intel.com
Subject: Re: [net-2.6 PATCH 1/3] ixgbevf: Fix VF Stats accounting after reset
Date: Fri, 19 Mar 2010 21:06:11 -0700 (PDT) [thread overview]
Message-ID: <20100319.210611.71090762.davem@davemloft.net> (raw)
In-Reply-To: <20100319125950.9799.70157.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Fri, 19 Mar 2010 05:59:52 -0700
> From: Greg Rose <gregory.v.rose@intel.com>
>
> The counters in the 82599 Virtual Function are not clear on read. They
> accumulate to the maximum value and then roll over. They are also not
> cleared when the VF executes a soft reset, so it is possible they are
> non-zero when the driver loads and starts. This has all been accounted
> for in the code that keeps the stats up to date but there is one case
> that is not. When the PF driver is reset the counters in the VF are
> all reset to zero. This adds an additional accounting overhead into
> the VF driver when the PF is reset under its feet. This patch adds
> additional counters that are used by the VF driver to accumulate and
> save stats after a PF reset has been detected. Prior to this patch
> displaying the stats in the VF after the PF has reset would show
> bogus data.
>
> Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
prev parent reply other threads:[~2010-03-20 4:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 12:59 [net-2.6 PATCH 1/3] ixgbevf: Fix VF Stats accounting after reset Jeff Kirsher
2010-03-19 13:00 ` [net-2.6 PATCH 2/3] ixgbevf: Shorten up delay timer for watchdog task Jeff Kirsher
2010-03-20 4:06 ` David Miller
2010-03-19 13:00 ` [net-2.6 PATCH 3/3] ixgbevf: Message formatting cleanups Jeff Kirsher
2010-03-20 4:06 ` David Miller
2010-03-20 4:06 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100319.210611.71090762.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=gregory.v.rose@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).