From: Tom Goff <thomas.goff@boeing.com>
To: netdev@vger.kernel.org
Subject: [PATCH] netdev: don't always reset iflink when registering
Date: Fri, 19 Mar 2010 18:39:17 -0700 [thread overview]
Message-ID: <20100320013917.GB13239@boeing.com> (raw)
Bound tunnel devices set their iflink to the ifindex of the underlying
network interface when created. It shouldn't be reset by the
registration process.
Signed-off-by: Tom Goff <thomas.goff@boeing.com>
---
net/core/dev.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 59d4394..c00d625 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -5067,7 +5067,8 @@ int register_netdevice(struct net_device *dev)
netdev_set_addr_lockdep_class(dev);
netdev_init_queue_locks(dev);
- dev->iflink = -1;
+ if (dev->iflink <= 0)
+ dev->iflink = -1;
/* Init, if this function is available */
if (dev->netdev_ops->ndo_init) {
--
1.6.3.3
next reply other threads:[~2010-03-20 2:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-20 1:39 Tom Goff [this message]
2010-03-22 17:42 ` [PATCH] netdev: don't always reset iflink when registering Patrick McHardy
2010-03-22 19:06 ` Goff, Thomas
2010-03-23 3:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100320013917.GB13239@boeing.com \
--to=thomas.goff@boeing.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).