From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: timo.teras@iki.fi, netdev@vger.kernel.org
Subject: Re: [PATCH] xfrm: cache bundle lookup results in flow cache
Date: Sun, 21 Mar 2010 18:26:27 -0700 (PDT) [thread overview]
Message-ID: <20100321.182627.214231065.davem@davemloft.net> (raw)
In-Reply-To: <20100320151751.GB2950@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sat, 20 Mar 2010 23:17:51 +0800
> Now Dave, my impression is that we picked the per-cpu design
> because it was the best data structure we had back in 2002,
> right?
Basically.
It was envisioned that flows at that level of detail would be spread
between different cpus, and that individual flows wouldn't propagate
onto multiple cpus much, if at all. And if they did, no big deal we
have an entry in the cache of those cpus.
Do we know cases where it happens often?
In any event, RCU would certainly fit the bill just as easily and I
have no qualms against going in that direction.
Timo mentioned the socket overrides, we handle them at the top level
right before we look into the flow cache and I think it should stay
that way and we shouldn't bother tossing those into the flow cache at
all. Just my humble opinion on this :-)
next prev parent reply other threads:[~2010-03-22 1:26 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-15 12:20 [PATCH] xfrm: cache bundle lookup results in flow cache Timo Teras
2010-03-17 13:07 ` Herbert Xu
2010-03-17 14:16 ` Timo Teräs
2010-03-17 14:58 ` Herbert Xu
2010-03-17 15:56 ` Timo Teräs
2010-03-17 16:32 ` Timo Teräs
2010-03-18 19:30 ` Timo Teräs
2010-03-19 0:31 ` Herbert Xu
2010-03-19 5:48 ` Timo Teräs
2010-03-19 6:03 ` Herbert Xu
2010-03-19 6:21 ` Timo Teräs
2010-03-19 7:17 ` Herbert Xu
2010-03-19 7:27 ` Timo Teräs
2010-03-19 0:32 ` Herbert Xu
2010-03-19 7:20 ` Herbert Xu
2010-03-19 7:48 ` Timo Teräs
2010-03-19 8:29 ` Herbert Xu
2010-03-19 8:37 ` Timo Teräs
2010-03-19 8:47 ` Herbert Xu
2010-03-19 9:12 ` Timo Teräs
2010-03-19 9:32 ` Herbert Xu
2010-03-19 9:53 ` Timo Teräs
2010-03-20 15:17 ` Herbert Xu
2010-03-20 16:26 ` Timo Teräs
2010-03-21 0:46 ` Herbert Xu
2010-03-21 7:34 ` Timo Teräs
2010-03-21 8:31 ` Timo Teräs
2010-03-22 3:52 ` Herbert Xu
2010-03-22 18:03 ` Timo Teräs
2010-03-23 7:28 ` Timo Teräs
2010-03-23 7:42 ` Herbert Xu
2010-03-23 9:19 ` Timo Teräs
2010-03-23 9:41 ` Herbert Xu
2010-03-22 1:26 ` David Miller [this message]
2010-03-22 1:28 ` David Miller
2010-03-22 1:32 ` Herbert Xu
2010-03-22 1:36 ` David Miller
2010-03-22 1:40 ` Herbert Xu
2010-03-22 3:12 ` David Miller
2010-03-22 3:52 ` Herbert Xu
2010-03-22 18:31 ` Timo Teräs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100321.182627.214231065.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=timo.teras@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).