From: David Miller <davem@davemloft.net>
To: robert@herjulf.net
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] pktgen node allocation
Date: Sun, 21 Mar 2010 20:37:44 -0700 (PDT) [thread overview]
Message-ID: <20100321.203744.43021126.davem@davemloft.net> (raw)
In-Reply-To: <19363.32154.39665.185451@gargle.gargle.HOWL>
From: robert@herjulf.net
Date: Fri, 19 Mar 2010 14:35:22 +0100
>
> Eric Dumazet writes:
> > Le vendredi 19 mars 2010 à 09:44 +0100, Robert Olsson a écrit :
> >
> > I cannot understand how this can help.
> >
> > __netdev_alloc_skb() is supposed to already take into account NUMA
> > properties :
> >
> > int node = dev->dev.parent ? dev_to_node(dev->dev.parent) : -1;
> >
> > If this doesnt work, we should correct core stack, not only pktgen :)
> >
> > Are you allocating memory in the node where pktgen CPU is running or the
> > node close to the NIC ?
>
> I didn't say it should help the idea was to give some hooks to
> experiment and see effects with different node memory allocations.
> There are many degrees of freedom wrt buses(device)/CPU/menory.
I think it's a useful feature and by default the netdev alloc
is still used, so... applied to net-next-2.6
prev parent reply other threads:[~2010-03-22 3:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 8:44 [PATCH] pktgen node allocation Robert Olsson
2010-03-19 9:28 ` Eric Dumazet
2010-03-19 13:35 ` robert
2010-03-19 13:47 ` Eric Dumazet
2010-03-22 6:24 ` Robert Olsson
2010-03-22 7:43 ` Eric Dumazet
2010-03-22 18:05 ` Robert Olsson
2010-03-22 3:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100321.203744.43021126.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=robert@herjulf.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).