From: David Miller <davem@davemloft.net>
To: peter.chubb@nicta.com.au
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Improved network performance by balancing Rx against other work
Date: Sun, 21 Mar 2010 21:24:49 -0700 (PDT) [thread overview]
Message-ID: <20100321.212449.85412927.davem@davemloft.net> (raw)
In-Reply-To: <8739ztrnrp.wl%peterc@chubb.wattle.id.au>
From: Peter Chubb <peter.chubb@nicta.com.au>
Date: Mon, 22 Mar 2010 15:19:54 +1100
> David> It's one of the best drivers in the locking area.
>
> It looked good from that aspect, but used too many features of NAPI
> for me to modify quickly, and still have a simple and
> easy-to-understand patch.
What's so complicated about it? All of the NAPI logic is
locks into a wrapper function that encapsulates all of
the top-level budget and interrupt masking logic.
> Anyway, I'm intending to try to reproduce the results with a different
> driver, as I said.
Well, you do so at your own peril. tg3 is the best, whereas
r8169 is really awful and people report NAPI wedges with it
all the time.
next prev parent reply other threads:[~2010-03-22 4:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 2:55 [PATCH] Improved network performance by balancing Rx against other work Peter Chubb
2010-03-22 3:21 ` David Miller
2010-03-22 4:04 ` Peter Chubb
2010-03-22 4:11 ` David Miller
2010-03-22 4:19 ` Peter Chubb
2010-03-22 4:24 ` David Miller [this message]
2010-03-22 13:27 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100321.212449.85412927.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=peter.chubb@nicta.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).