From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com, nicholasx.d.nunley@intel.com
Subject: Re: [net-next-2.6 PATCH] igb: add IntMode module parameter
Date: Mon, 22 Mar 2010 18:28:27 -0700 (PDT) [thread overview]
Message-ID: <20100322.182827.180417968.davem@davemloft.net> (raw)
In-Reply-To: <20100323000519.19902.14802.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 22 Mar 2010 17:06:20 -0700
> From: Nick Nunley <nicholasx.d.nunley@intel.com>
>
> This patch adds the IntMode module parameter to igb. This
> allows user selection of interrupt mode (MSI-X, MSI, legacy)
> on driver load.
>
> Signed-off-by: Nicholas Nunley <nicholasx.d.nunley@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
And IGB is special and needs this for what reason?
If there are real interrupt issues then:
1) Diagnosing via verification of the problem can be simply performed
by asking the user to pass the generic kernel boot option to
globally disable MSI and friends.
2) Specifically disabling it for buggy parts belongs in the
driver or in the PCI quirk tables.
So from just about any angle, this module option makes no sense.
So I'm not applying it, sorry.
prev parent reply other threads:[~2010-03-23 1:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 0:06 [net-next-2.6 PATCH] igb: add IntMode module parameter Jeff Kirsher
2010-03-23 1:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100322.182827.180417968.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nicholasx.d.nunley@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).