From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: amwang@redhat.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, elendil@planet.nl
Subject: Re: [Patch v2] netpoll: warn when there are spaces in parameters
Date: Mon, 22 Mar 2010 20:06:47 -0700 (PDT) [thread overview]
Message-ID: <20100322.200647.163253192.davem@davemloft.net> (raw)
In-Reply-To: <20100322123046.GA4288@hmsreliant.think-freely.org>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Mon, 22 Mar 2010 08:30:46 -0400
> On Mon, Mar 22, 2010 at 04:59:58AM -0400, Amerigo Wang wrote:
>> v2: update according to Frans' comments.
>>
>> Currently, if we leave spaces before dst port,
>> netconsole will silently accept it as 0. Warn about this.
>>
>> Also, when spaces appear in other places, make them
>> visible in error messages.
>>
>> Signed-off-by: WANG Cong <amwang@redhat.com>
...
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
Applied, thanks!
next prev parent reply other threads:[~2010-03-23 3:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-22 8:59 [Patch v2] netpoll: warn when there are spaces in parameters Amerigo Wang
2010-03-22 12:30 ` Neil Horman
2010-03-23 3:06 ` David Miller [this message]
2010-03-22 22:22 ` Matt Mackall
2010-03-23 1:44 ` Cong Wang
2010-03-23 4:24 ` Matt Mackall
2010-03-23 4:34 ` Cong Wang
2010-03-23 4:45 ` Matt Mackall
2010-03-23 4:56 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100322.200647.163253192.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amwang@redhat.com \
--cc=elendil@planet.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).