* [PATCH] ixgbevf: Message formatting fixup
[not found] <201003221759.o2MHxFlh015632@hera.kernel.org>
@ 2010-03-22 19:12 ` Joe Perches
2010-03-23 3:08 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Joe Perches @ 2010-03-22 19:12 UTC (permalink / raw)
To: Greg Rose, David S. Miller; +Cc: netdev, Jeff Kirsher
Commit 29b8dd024bd48c3d1d1e5140f5bbb683786f998e
left a trailing ", " after a message.
Fix it and make the text used a bit smaller when DEBUG is #defined
Signed-off-by: Joe Perches <joe@perches.com>
---
diff --git a/drivers/net/ixgbevf/ixgbevf_main.c b/drivers/net/ixgbevf/ixgbevf_main.c
index d6cbd94..19e93a4 100644
--- a/drivers/net/ixgbevf/ixgbevf_main.c
+++ b/drivers/net/ixgbevf/ixgbevf_main.c
@@ -2417,9 +2417,9 @@ static void ixgbevf_watchdog_task(struct work_struct *work)
if (link_up) {
if (!netif_carrier_ok(netdev)) {
- hw_dbg(&adapter->hw, "NIC Link is Up %s, ",
- ((link_speed == IXGBE_LINK_SPEED_10GB_FULL) ?
- "10 Gbps\n" : "1 Gbps\n"));
+ hw_dbg(&adapter->hw, "NIC Link is Up, %u Gbps\n",
+ (link_speed == IXGBE_LINK_SPEED_10GB_FULL) ?
+ 10 : 1);
netif_carrier_on(netdev);
netif_tx_wake_all_queues(netdev);
} else {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ixgbevf: Message formatting fixup
2010-03-22 19:12 ` [PATCH] ixgbevf: Message formatting fixup Joe Perches
@ 2010-03-23 3:08 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-03-23 3:08 UTC (permalink / raw)
To: joe; +Cc: gregory.v.rose, netdev, jeffrey.t.kirsher
From: Joe Perches <joe@perches.com>
Date: Mon, 22 Mar 2010 12:12:37 -0700
> Commit 29b8dd024bd48c3d1d1e5140f5bbb683786f998e
> left a trailing ", " after a message.
> Fix it and make the text used a bit smaller when DEBUG is #defined
>
> Signed-off-by: Joe Perches <joe@perches.com>
Looks good, applied, thanks Joe.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-23 3:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <201003221759.o2MHxFlh015632@hera.kernel.org>
2010-03-22 19:12 ` [PATCH] ixgbevf: Message formatting fixup Joe Perches
2010-03-23 3:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).