From: David Miller <davem@davemloft.net>
To: thomas.goff@boeing.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] netlink: use the appropriate namespace pid
Date: Mon, 22 Mar 2010 20:25:26 -0700 (PDT) [thread overview]
Message-ID: <20100322.202526.141239221.davem@davemloft.net> (raw)
In-Reply-To: <20100320013850.GA13239@boeing.com>
From: Tom Goff <thomas.goff@boeing.com>
Date: Fri, 19 Mar 2010 18:38:50 -0700
> This was included in OpenVZ kernels but wasn't integrated upstream.
>>From git://git.openvz.org/pub/linux-2.6.24-openvz:
>
> commit 5c69402f18adf7276352e051ece2cf31feefab02
> Author: Alexey Dobriyan <adobriyan@openvz.org>
> Date: Mon Dec 24 14:37:45 2007 +0300
>
> netlink: fixup ->tgid to work in multiple PID namespaces
>
> Signed-off-by: Tom Goff <thomas.goff@boeing.com>
BTW, we're ok without this.
The 'pid' in this code is just an arbitrary port number. We are
merely using the tgid to seed the port allocator, so it doesn't have
to be the real proper tgid.
I'm therefore dropping this for now. If Alexey can show why we
might need this, we can revisit the patch.
prev parent reply other threads:[~2010-03-23 3:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-20 1:38 [PATCH] netlink: use the appropriate namespace pid Tom Goff
2010-03-22 4:30 ` David Miller
2010-03-24 7:58 ` Alexey Dobriyan
2010-03-24 8:19 ` Alexey Dobriyan
2010-03-27 3:14 ` David Miller
2010-03-31 2:42 ` Goff, Thomas
2010-03-31 2:43 ` [PATCH] net_sched: minor netns related cleanup Tom Goff
2010-03-31 2:45 ` David Miller
2010-04-02 1:43 ` David Miller
2010-03-24 14:18 ` [PATCH] netlink: use the appropriate namespace pid Goff, Thomas
2010-03-27 3:15 ` David Miller
2010-03-23 3:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100322.202526.141239221.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=thomas.goff@boeing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).