From: David Miller <davem@davemloft.net>
To: JRottmann@LiPPERTEmbedded.de
Cc: Tristram.Ha@micrel.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ksz884x: fix return value of netdev_set_eeprom
Date: Tue, 23 Mar 2010 13:09:42 -0700 (PDT) [thread overview]
Message-ID: <20100323.130942.09762502.davem@davemloft.net> (raw)
In-Reply-To: <4BA8CEF6.2010707@LiPPERTEmbedded.de>
From: Jens Rottmann <JRottmann@LiPPERTEmbedded.de>
Date: Tue, 23 Mar 2010 15:23:50 +0100
> ksz884x: fix return value of netdev_set_eeprom
>
> netdev_set_eeprom() confused ethtool by just returning 1 on error
> instead of a proper -EINVAL.
>
> Signed-off-by: Jens Rottmann <JRottmann@LiPPERTEmbedded.de>
Applied, thank you.
prev parent reply other threads:[~2010-03-23 20:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 14:23 [PATCH] ksz884x: fix return value of netdev_set_eeprom Jens Rottmann
2010-03-23 20:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100323.130942.09762502.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=JRottmann@LiPPERTEmbedded.de \
--cc=Tristram.Ha@micrel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).