From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org,
gospo@redhat.com, vasu.dev@intel.com
Subject: Re: [PATCH v2 1/2] vlan: adds vlan_dev_select_queue
Date: Wed, 24 Mar 2010 11:11:50 -0700 (PDT) [thread overview]
Message-ID: <20100324.111150.112828699.davem@davemloft.net> (raw)
In-Reply-To: <1269410022.2915.49.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 24 Mar 2010 06:53:42 +0100
> Le mardi 23 mars 2010 à 17:41 -0700, Jeff Kirsher a écrit :
>> From: Vasu Dev <vasu.dev@intel.com>
>>
>> This is required to correctly select vlan tx queue for a driver
>> supporting multi tx queue with ndo_select_queue implemented since
>> currently selected vlan tx queue is unaligned to selected queue by
>> real net_devce ndo_select_queue.
>>
>> Unaligned vlan tx queue selection causes thrash with higher vlan
>> tx lock contention for least fcoe traffic and wrong socket tx
>> queue_mapping for ixgbe having ndo_select_queue implemented.
>>
>> -v2
>>
>> As per Eric Dumazet<eric.dumazet@gmail.com> comments, mirrored
>> vlan net_device_ops to have them with and without vlan_dev_select_queue
>> and then select according to real dev ndo_select_queue present or not
>> for a vlan net_device. This is to completely skip vlan_dev_select_queue
>> calling for real net_device not supporting ndo_select_queue.
>>
>> Signed-off-by: Vasu Dev <vasu.dev@intel.com>
>> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>> ---
>>
>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
prev parent reply other threads:[~2010-03-24 18:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 0:41 [PATCH v2 1/2] vlan: adds vlan_dev_select_queue Jeff Kirsher
2010-03-24 0:42 ` [PATCH v2 2/2] vlan: updates vlan real_num_tx_queues Jeff Kirsher
2010-03-24 6:44 ` Eric Dumazet
2010-03-24 18:11 ` David Miller
2010-03-24 5:53 ` [PATCH v2 1/2] vlan: adds vlan_dev_select_queue Eric Dumazet
2010-03-24 6:30 ` David Miller
2010-03-24 6:45 ` Eric Dumazet
2010-03-24 18:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100324.111150.112828699.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=vasu.dev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).