Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: amit.salecha@qlogic.com
Cc: netdev@vger.kernel.org, ameen.rahman@qlogic.com
Subject: Re: [PATCH 7/8] netxen: added sanity check for pci map
Date: Wed, 24 Mar 2010 11:46:20 -0700 (PDT)	[thread overview]
Message-ID: <20100324.114620.37223701.davem@davemloft.net> (raw)
In-Reply-To: <1269437363-2606-8-git-send-email-amit.salecha@qlogic.com>


1) You're leaking the ioremap() mappings in this patch when one of
   them fails.

2) This is too many patches to be submitting to net-2.6 this late in
   the post-merge-window time period.  If you want some of these fixes
   in net-2.6 pick a small set of the most important ones and
   resubmit.

I'm tossing this whole series for now.

  reply	other threads:[~2010-03-24 18:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-24 13:29 [PATCH 0/8]netxen: Validate and fix fw load Amit Kumar Salecha
2010-03-24 13:29 ` [PATCH 1/8] netxen: fix tx csum status Amit Kumar Salecha
2010-03-24 13:29 ` [PATCH 2/8] netxen: fix corner cases of firmware recovery Amit Kumar Salecha
2010-03-24 13:29 ` [PATCH 3/8] netxen: validate unified romimage Amit Kumar Salecha
2010-03-24 13:29 ` [PATCH 4/8] netxen: fix bios version calculation Amit Kumar Salecha
2010-03-24 13:29 ` [PATCH 5/8] netxen: fix fw load from file Amit Kumar Salecha
2010-03-24 13:29 ` [PATCH 6/8] netxen: fix warning in ioaddr for NX3031 chip Amit Kumar Salecha
2010-03-24 13:29 ` [PATCH 7/8] netxen: added sanity check for pci map Amit Kumar Salecha
2010-03-24 18:46   ` David Miller [this message]
2010-03-24 13:29 ` [PATCH 8/8] netxen: update version to 4.0.73 Amit Kumar Salecha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100324.114620.37223701.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ameen.rahman@qlogic.com \
    --cc=amit.salecha@qlogic.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox