From: David Miller <davem@davemloft.net>
To: nicolas.dichtel@dev.6wind.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: ipmr/ip6mr: prevent out-of-bounds vif_table access
Date: Fri, 26 Mar 2010 11:11:45 -0700 (PDT) [thread overview]
Message-ID: <20100326.111145.76087355.davem@davemloft.net> (raw)
In-Reply-To: <4BACECA6.2050506@dev.6wind.com>
From: Nicolas Dichtel <nicolas.dichtel@dev.6wind.com>
Date: Fri, 26 Mar 2010 18:19:34 +0100
> yes, but I think that it is not enough, ip[6]mr_mfc_add() is only
> called via setsockopt().
>
> When a multicast packet arrived in ip6_mr_input(), if there is no
> cache ip6mr_cache_unresolved() will be called and this function will
> add an entry with parent == 65535.
>
> And the second problem is that when a vif is removed, no cleanup is
> made in cache entry. Hence, we can have a cache entry which points to
> an invalid vif (dev is set ot NULL).
Ok, I'll take another look at your patch, thanks for
explaining.
next prev parent reply other threads:[~2010-03-26 18:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 9:45 [PATCH] net: ipmr/ip6mr: prevent out-of-bounds vif_table access Nicolas Dichtel
2010-03-26 16:51 ` David Miller
2010-03-26 17:19 ` Nicolas Dichtel
2010-03-26 18:11 ` David Miller [this message]
2010-03-27 15:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100326.111145.76087355.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@dev.6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).