From: David Miller <davem@davemloft.net>
To: grundler@parisc-linux.org
Cc: kyle@mcmartin.ca, netdev@vger.kernel.org, error27@gmail.com
Subject: Re: Null dereference in uli526x_rx_packet()
Date: Fri, 26 Mar 2010 20:21:25 -0700 (PDT) [thread overview]
Message-ID: <20100326.202125.238456279.davem@davemloft.net> (raw)
In-Reply-To: <20100207071540.GA9908@lackof.org>
From: Grant Grundler <grundler@parisc-linux.org>
Date: Sun, 7 Feb 2010 00:15:40 -0700
> On Sat, Mar 28, 2009 at 11:59:31PM -0700, David Miller wrote:
> ...
>> > Patch below looks right to me. Clobbering the skb is certainly wrong.
>> >
>> > Acked-by: Grant Grundler <grundler@parisc-linux.org>
>>
>> It looks correct to me, can we get a proper submission with
>> signoffs etc.?
>
> Dave,
> Looks like this patch was never resubmitted.
>
> Kyle, can you look at http://lists.openwall.net/netdev/2009/03/27/117
> and resubmit the code you had then with my "Acked-by" added please?
>
> Or if you don't want to touch it, let me know and I'll resurrect it.
I got tired of waiting for this resubmission (a month and a half) and
just applied the most recent version of the patch to net-2.6.
It looked correct to me too.
next prev parent reply other threads:[~2010-03-27 3:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 10:31 Null dereference in uli526x_rx_packet() Dan Carpenter
2009-03-28 2:47 ` Kyle McMartin
2009-03-28 3:23 ` Kyle McMartin
2009-03-29 5:35 ` Grant Grundler
2009-03-29 6:59 ` David Miller
2009-04-13 2:45 ` Grant Grundler
2009-04-13 2:56 ` David Miller
2010-02-07 7:15 ` Grant Grundler
2010-03-27 3:21 ` David Miller [this message]
2010-03-27 6:08 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100326.202125.238456279.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=error27@gmail.com \
--cc=grundler@parisc-linux.org \
--cc=kyle@mcmartin.ca \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).