From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: xemul@openvz.org, dada1@cosmosbay.com, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] ipv4: Restart rt_intern_hash after emergency rebuild (v2)
Date: Fri, 26 Mar 2010 20:58:24 -0700 (PDT) [thread overview]
Message-ID: <20100326.205824.143616642.davem@davemloft.net> (raw)
In-Reply-To: <20100325131721.GA17675@shamino.rdu.redhat.com>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Thu, 25 Mar 2010 09:17:21 -0400
> On Thu, Mar 25, 2010 at 10:51:22AM +0300, Pavel Emelyanov wrote:
>> The the rebuild changes the genid which in turn is used at
>> the hash calculation. Thus if we don't restart and go on with
>> inserting the rt will happen in wrong chain.
>>
>> (Fixed Neil's comment about the index passed into the rt_intern_hash)
>>
>> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
> Thanks! I think this is pretty reasonable.
> Reviewed-by: Neil Horman <nhorman@tuxdriver.com>
Applied, thanks.
prev parent reply other threads:[~2010-03-27 3:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 17:43 [PATCH 2/2] ipv4: Restart rt_intern_hash after emergency rebuild Pavel Emelyanov
2010-03-24 20:21 ` Neil Horman
2010-03-25 7:44 ` Pavel Emelyanov
2010-03-25 7:51 ` [PATCH 2/2] ipv4: Restart rt_intern_hash after emergency rebuild (v2) Pavel Emelyanov
2010-03-25 13:17 ` Neil Horman
2010-03-27 3:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100326.205824.143616642.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dada1@cosmosbay.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).