netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [net-next-2.6 PATCH 4/8] vxge: Fixed "ethtool -d" prints.
@ 2010-03-29  8:10 Sreenivasa Honnur
  2010-03-29 23:59 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Sreenivasa Honnur @ 2010-03-29  8:10 UTC (permalink / raw)
  To: davem; +Cc: netdev, support

- Fixed "ethtool -d" prints
- reg_space pointer was getting over written, updating it correctly.

Signed-off-by: Sreenivasa Honnur <sreenivasa.honnur@neterion.com>
Signed-off-by: Ramkrishna Vepa <ram.vepa@neterion.com>
---
diff -urpN patch3/drivers/net/vxge/vxge-ethtool.c patch4/drivers/net/vxge/vxge-ethtool.c
--- patch3/drivers/net/vxge/vxge-ethtool.c	2010-03-19 16:17:46.000000000 +0530
+++ patch4/drivers/net/vxge/vxge-ethtool.c	2010-03-19 16:22:15.000000000 +0530
@@ -108,7 +108,7 @@ static void vxge_ethtool_gregs(struct ne
 	int index, offset;
 	enum vxge_hw_status status;
 	u64 reg;
-	u8 *reg_space = (u8 *) space;
+	u64 *reg_space = (u64 *) space;
 	struct vxgedev *vdev = (struct vxgedev *)netdev_priv(dev);
 	struct __vxge_hw_device  *hldev = (struct __vxge_hw_device *)
 					pci_get_drvdata(vdev->pdev);
@@ -128,8 +128,7 @@ static void vxge_ethtool_gregs(struct ne
 						__func__, __LINE__);
 				return;
 			}
-
-			memcpy((reg_space + offset), &reg, 8);
+			*reg_space++ = reg;
 		}
 	}
 }


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [net-next-2.6 PATCH 4/8] vxge: Fixed "ethtool -d" prints.
  2010-03-29  8:10 [net-next-2.6 PATCH 4/8] vxge: Fixed "ethtool -d" prints Sreenivasa Honnur
@ 2010-03-29 23:59 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-03-29 23:59 UTC (permalink / raw)
  To: Sreenivasa.Honnur; +Cc: netdev, support

From: Sreenivasa Honnur <Sreenivasa.Honnur@neterion.com>
Date: Mon, 29 Mar 2010 04:10:33 -0400 (EDT)

> - Fixed "ethtool -d" prints
> - reg_space pointer was getting over written, updating it correctly.
> 
> Signed-off-by: Sreenivasa Honnur <sreenivasa.honnur@neterion.com>
> Signed-off-by: Ramkrishna Vepa <ram.vepa@neterion.com>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-03-29 23:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-29  8:10 [net-next-2.6 PATCH 4/8] vxge: Fixed "ethtool -d" prints Sreenivasa Honnur
2010-03-29 23:59 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).