From: David Miller <davem@davemloft.net>
To: steve@digidescorp.com
Cc: netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, pekkas@netcore.fi,
jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
linux-kernel@vger.kernel.org, monstr@monstr.eu,
karl@hiramoto.org
Subject: Re: [PATCH] net: Fix oops from tcp_collapse() when using splice()
Date: Tue, 30 Mar 2010 13:56:22 -0700 (PDT) [thread overview]
Message-ID: <20100330.135622.233398574.davem@davemloft.net> (raw)
In-Reply-To: <20100330.134741.203608594.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Tue, 30 Mar 2010 13:47:41 -0700 (PDT)
> From: "Steven J. Magnani" <steve@digidescorp.com>
> Date: Tue, 30 Mar 2010 15:45:13 -0500
>
>> tcp_read_sock() can have a eat skbs without immediately advancing copied_seq.
>> This can cause a panic in tcp_collapse() if it is called as a result
>> of the recv_actor dropping the socket lock.
>>
>> A userspace program that splices data from a socket to either another
>> socket or to a file can trigger this bug.
>>
>> Signed-off-by: Steven J. Magnani <steve@digidescorp.com>
>
> Thanks for fixing this I'll look at your patch more closely
> right now.
Patch applied, thanks Steven!
prev parent reply other threads:[~2010-03-30 20:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 20:45 [PATCH] net: Fix oops from tcp_collapse() when using splice() Steven J. Magnani
2010-03-30 20:47 ` David Miller
2010-03-30 20:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100330.135622.233398574.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=karl@hiramoto.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=monstr@monstr.eu \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=steve@digidescorp.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).