From: Stephen Hemminger <shemminger@vyatta.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
Andreas Henriksson <andreas@fatal.se>,
Patrick McHardy <kaber@trash.net>, jamal <hadi@cyberus.ca>,
netdev@vger.kernel.org
Subject: Re: XT_ALIGN changed to use ALIGN breaks iproute2
Date: Tue, 30 Mar 2010 08:29:02 -0700 [thread overview]
Message-ID: <20100330082902.6d64d21d@nehalam> (raw)
In-Reply-To: <1269961278.2174.11.camel@achroite.uk.solarflarecom.com>
On Tue, 30 Mar 2010 16:01:18 +0100
Ben Hutchings <bhutchings@solarflare.com> wrote:
> On Tue, 2010-03-30 at 16:15 +0300, Alexey Dobriyan wrote:
> > On Tue, Mar 30, 2010 at 12:28 PM, Andreas Henriksson <andreas@fatal.se> wrote:
> > > You updated the kernel header include/linux/netfilter/x_tables.h
> > > in torvalds/linux-2.6.git commit 42107f5009da223daa800d6da6904d77297ae829
> > > with the comment "Use ALIGN() macro while I'm at it for same types.".
> > >
> > > When this header was synced into iproute2 the build broke because the
> > > ALIGN macro apparently only is defined in kernel headers.
> > >
> > > (For iproute2 the problem was introduced in
> > > 8ecdcce08319d0e39b0d32c1d17db3f69d85a35c and found by Stephen
> > > and worked around in 609ceb807deba8e23 and edaaa11e5a3cf2c9c1a39)
> > >
> > > I'm guessing the problem in the iproute2 header sync is just a heads
> > > up for what's going to happen when distributions updates their
> > > system headers to match linux 2.6.33.
> > >
> > >
> > > Could someone who knows how the userspace version of the kernel
> > > headers are generated please find a suitable solution?
> >
> > We can export ALIGN to userspace, but the name is so generic,
> > so it's not clear what breakage more risky.
>
I put a hack in m_xt.c to keep iproute2 building.
But this is a temporary workaround until you guys figure out the
right answer.
--
next prev parent reply other threads:[~2010-03-30 15:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 9:28 XT_ALIGN changed to use ALIGN breaks iproute2 Andreas Henriksson
2010-03-30 13:15 ` Alexey Dobriyan
2010-03-30 15:01 ` Ben Hutchings
2010-03-30 15:29 ` Stephen Hemminger [this message]
2010-04-01 10:50 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100330082902.6d64d21d@nehalam \
--to=shemminger@vyatta.com \
--cc=adobriyan@gmail.com \
--cc=andreas@fatal.se \
--cc=bhutchings@solarflare.com \
--cc=hadi@cyberus.ca \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).