From: Stephen Hemminger <shemminger@vyatta.com>
To: James Chapman <jchapman@katalix.com>
Cc: netdev@vger.kernel.org
Subject: Re: Re [RFC PATCH 1/2] iproute2: Add libnl support.
Date: Tue, 30 Mar 2010 14:40:12 -0700	[thread overview]
Message-ID: <20100330144012.6ad28c1f@nehalam> (raw)
In-Reply-To: <4BB1ACDA.8030808@katalix.com>
On Tue, 30 Mar 2010 08:48:42 +0100
James Chapman <jchapman@katalix.com> wrote:
> Stephen Hemminger wrote:
> >> This patch links the ip utility with libnl, which must be separately
> >> installed. This lets new functionality use libnl to implement its
> >> netlink interfaces.
> >>
> >> Package developers will need to add libnl to the iproute2 package
> >> dependencies.
> >> ---
> >>  Makefile |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > No. I don't want to make iproute2 dependent on libnl.
> > It doesn't make sense to have dependency without major need for new
> > functionality.  There are already netlink library routines in iproute2
> 
> True, but libnetlink doesn't provide utility routines for building genl
> interfaces like it does, say, for rtnl. To use libnetlink for this code,
> we'd have to c&p some code from genl/ctrl.c to handle the interface
> family registration, for example. It's all there in libnl already.
> 
> But I understand your reservation about introducing a new library
> dependency. Since the rest of our netlink code uses libnl, I'm leaning
> towards having a separate utility for these commands so we can keep it
> libnl.
> 
Please use extend genl/ctrl.c to handle your lt2pv3 messages.
     prev parent reply	other threads:[~2010-03-30 21:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-29 21:06 Re [RFC PATCH 1/2] iproute2: Add libnl support Stephen Hemminger
2010-03-30  7:48 ` James Chapman
2010-03-30 21:40   ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=20100330144012.6ad28c1f@nehalam \
    --to=shemminger@vyatta.com \
    --cc=jchapman@katalix.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).