Re [RFC PATCH 1/2] iproute2: Add libnl support.

Re [RFC PATCH 1/2] iproute2: Add libnl support.

[Stephen Hemminger]

> This patch links the ip utility with libnl, which must be separately
> installed. This lets new functionality use libnl to implement its
> netlink interfaces.
> 
> Package developers will need to add libnl to the iproute2 package
> dependencies.
> ---
>  Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

No. I don't want to make iproute2 dependent on libnl.
It doesn't make sense to have dependency without major need for new
functionality.  There are already netlink library routines in iproute2

Re: Re [RFC PATCH 1/2] iproute2: Add libnl support.

[James Chapman]

Stephen Hemminger wrote:
>> This patch links the ip utility with libnl, which must be separately
>> installed. This lets new functionality use libnl to implement its
>> netlink interfaces.
>>
>> Package developers will need to add libnl to the iproute2 package
>> dependencies.
>> ---
>>  Makefile |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> No. I don't want to make iproute2 dependent on libnl.
> It doesn't make sense to have dependency without major need for new
> functionality.  There are already netlink library routines in iproute2

True, but libnetlink doesn't provide utility routines for building genl
interfaces like it does, say, for rtnl. To use libnetlink for this code,
we'd have to c&p some code from genl/ctrl.c to handle the interface
family registration, for example. It's all there in libnl already.

But I understand your reservation about introducing a new library
dependency. Since the rest of our netlink code uses libnl, I'm leaning
towards having a separate utility for these commands so we can keep it
libnl.

-- 
James Chapman
Katalix Systems Ltd
http://www.katalix.com
Catalysts for your Embedded Linux software development

Re: Re [RFC PATCH 1/2] iproute2: Add libnl support.

[Stephen Hemminger]

On Tue, 30 Mar 2010 08:48:42 +0100
James Chapman <jchapman@katalix.com> wrote:

> Stephen Hemminger wrote:
> >> This patch links the ip utility with libnl, which must be separately
> >> installed. This lets new functionality use libnl to implement its
> >> netlink interfaces.
> >>
> >> Package developers will need to add libnl to the iproute2 package
> >> dependencies.
> >> ---
> >>  Makefile |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > No. I don't want to make iproute2 dependent on libnl.
> > It doesn't make sense to have dependency without major need for new
> > functionality.  There are already netlink library routines in iproute2
> 
> True, but libnetlink doesn't provide utility routines for building genl
> interfaces like it does, say, for rtnl. To use libnetlink for this code,
> we'd have to c&p some code from genl/ctrl.c to handle the interface
> family registration, for example. It's all there in libnl already.
> 
> But I understand your reservation about introducing a new library
> dependency. Since the rest of our netlink code uses libnl, I'm leaning
> towards having a separate utility for these commands so we can keep it
> libnl.
> 

Please use extend genl/ctrl.c to handle your lt2pv3 messages.