From: Erkki Seppala <flux-lkml@inside.org>
To: netdev <netdev@vger.kernel.org>
Subject: Re: Tiny patch (w/ discussion) to provide the peer information on unix domain sockets
Date: Tue, 30 Mar 2010 20:39:04 +0300 [thread overview]
Message-ID: <20100330173904.GB12709@coffee.modeemi.cs.tut.fi> (raw)
In-Reply-To: <1269961013.2012.61.camel@edumazet-laptop>
Hi Eric,
On Tue, Mar 30, 2010 at 04:56:53PM +0200, Eric Dumazet wrote:
> Such patches should be sent to netdev
Oops! Thanks for the pointer!
> I believe you missed some necessary locking.
I don't think so, because I don't actually dereference the other unix
address, I just print the its address.
> Prior art from Kenan Kalajdzic :
>
> http://patchwork.ozlabs.org/patch/46561/
Perhaps this would be a more decent solution (using the more
user-space compatible concept of inodes), although I think don't that
the backwards compatiblity for this kind of rarely used feature is
that critical, given the impact of the breakage seems to be quite low
as well.
I think the way forward in general should be that user space
applications actually look what columns are available and provide
future compatibility in that fashion. And empty fields should have
have some filler :).
--
_____________________________________________________________________
/ __// /__ ____ __ http://www.modeemi.fi/~flux/\ \
/ /_ / // // /\ \/ / \ /
/_/ /_/ \___/ /_/\_\@modeemi.fi \/
prev parent reply other threads:[~2010-03-30 17:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100330143512.GF7980@coffee.modeemi.cs.tut.fi>
2010-03-30 14:56 ` Tiny patch (w/ discussion) to provide the peer information on unix domain sockets Eric Dumazet
2010-03-30 17:39 ` Erkki Seppala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100330173904.GB12709@coffee.modeemi.cs.tut.fi \
--to=flux-lkml@inside.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).