From: David Miller <davem@davemloft.net>
To: amwang@redhat.com
Cc: ebiederm@xmission.com, linux-kernel@vger.kernel.org,
jpirko@redhat.com, shemminger@vyatta.com, netdev@vger.kernel.org,
bonding-devel@lists.sourceforge.net, fubar@us.ibm.com
Subject: Re: [Patch V3] bonding: fix potential deadlock in bond_uninit()
Date: Thu, 01 Apr 2010 17:26:35 -0700 (PDT) [thread overview]
Message-ID: <20100401.172635.38081142.davem@davemloft.net> (raw)
In-Reply-To: <4BB44BAC.2070304@redhat.com>
From: Cong Wang <amwang@redhat.com>
Date: Thu, 01 Apr 2010 15:30:52 +0800
> Eric W. Biederman wrote:
>> Amerigo Wang <amwang@redhat.com> writes:
>>
>>> bond_uninit() is invoked with rtnl_lock held, when it does
>>> destroy_workqueue()
>>> which will potentially flush all works in this workqueue, if we hold
>>> rtnl_lock
>>> again in the work function, it will deadlock.
>>>
>>> So move destroy_workqueue() to destructor where rtnl_lock is not held
>>> any more,
>>> suggested by Eric.
>> The error handling on creating a bond device needs to be updated as
>> well.
>>
>
> Done.
Applied, thanks.
prev parent reply other threads:[~2010-04-02 0:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 6:06 [Patch V2] bonding: fix potential deadlock in bond_uninit() Amerigo Wang
2010-04-01 6:12 ` Eric W. Biederman
2010-04-01 6:54 ` Cong Wang
2010-04-01 7:30 ` [Patch V3] " Cong Wang
2010-04-02 0:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100401.172635.38081142.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amwang@redhat.com \
--cc=bonding-devel@lists.sourceforge.net \
--cc=ebiederm@xmission.com \
--cc=fubar@us.ibm.com \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).