netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: mst@redhat.com
Cc: rusty@rustcorp.com.au, jpirko@redhat.com, xma@us.ibm.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio-net: move sg off stack
Date: Thu, 01 Apr 2010 19:26:48 -0700 (PDT)	[thread overview]
Message-ID: <20100401.192648.185498218.davem@davemloft.net> (raw)
In-Reply-To: <20100331124156.GA4598@redhat.com>

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Wed, 31 Mar 2010 15:41:58 +0300

> Move sg structure off stack and into virtnet_info structure.
> This helps remove extra sg_init_table calls as well as reduce
> stack usage.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> 
> Compile-tested only for now.
> Shirley, Rusty Russell, does this fix CONFIG_DEBUG_SG=y for you?

I'll apply this once I see some ACKs on testing.

Thanks.

  parent reply	other threads:[~2010-04-02  2:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-29 18:31 [PATCH next-next-2.6] virtio_net: missing sg_init_table Shirley Ma
2010-03-29 19:31 ` Thomas Müller
2010-03-30  1:19   ` [PATCH next-next-2.6 v2] " Shirley Ma
2010-03-31  1:32     ` David Miller
2010-03-31  9:20     ` Michael S. Tsirkin
2010-03-31 10:16       ` David Miller
2010-03-31 12:41         ` [PATCH] virtio-net: move sg off stack Michael S. Tsirkin
     [not found]         ` <20100331124156.GA4598@redhat.com>
2010-04-02  2:26           ` David Miller [this message]
2010-04-06  3:14             ` Rusty Russell
2010-03-30  1:19   ` [PATCH next-next-2.6] virtio_net: missing sg_init_table Shirley Ma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100401.192648.185498218.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jpirko@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=xma@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).