* [PATCH] r8169: clean up my printk uglyness
@ 2010-04-01 14:53 Neil Horman
2010-04-01 17:30 ` Neil Horman
0 siblings, 1 reply; 3+ messages in thread
From: Neil Horman @ 2010-04-01 14:53 UTC (permalink / raw)
To: netdev; +Cc: davem, romieu, nhorman, brandon
Fix formatting on r8169 printk
Brandon Philips noted that I had a spacing issue in my printk for the last r8169
patch that made it quite ugly. Fix that up and add the PFX macro to it as well
so it looks like the other r8169 printks
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
r8169.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 9674005..a119885 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -3227,8 +3227,8 @@ static void rtl8169_set_rxbufsize(struct rtl8169_private *tp,
unsigned int max_frame = mtu + VLAN_ETH_HLEN + ETH_FCS_LEN;
if (max_frame != 16383)
- printk(KERN_WARNING "WARNING! Changing of MTU on this NIC"
- "May lead to frame reception errors!\n");
+ printk(KERN_WARNING PFX "WARNING! Changing of MTU on this "
+ "NIC May lead to frame reception errors!\n");
tp->rx_buf_sz = (max_frame > RX_BUF_SIZE) ? max_frame : RX_BUF_SIZE;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] r8169: clean up my printk uglyness
2010-04-01 14:53 [PATCH] r8169: clean up my printk uglyness Neil Horman
@ 2010-04-01 17:30 ` Neil Horman
2010-04-02 2:33 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Neil Horman @ 2010-04-01 17:30 UTC (permalink / raw)
To: netdev; +Cc: davem, romieu, brandon
On Thu, Apr 01, 2010 at 10:53:56AM -0400, Neil Horman wrote:
> Fix formatting on r8169 printk
>
> Brandon Philips noted that I had a spacing issue in my printk for the last r8169
> patch that made it quite ugly. Fix that up and add the PFX macro to it as well
> so it looks like the other r8169 printks
>
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
>
>
Grr, yes thanks, V2, fixing my idiocy :)
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
r8169.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 9674005..a119885 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -3227,8 +3227,8 @@ static void rtl8169_set_rxbufsize(struct rtl8169_private *tp,
unsigned int max_frame = mtu + VLAN_ETH_HLEN + ETH_FCS_LEN;
if (max_frame != 16383)
- printk(KERN_WARNING "WARNING! Changing of MTU on this NIC"
- "May lead to frame reception errors!\n");
+ printk(KERN_WARNING PFX "WARNING! Changing of MTU on this "
+ "NIC may lead to frame reception errors!\n");
tp->rx_buf_sz = (max_frame > RX_BUF_SIZE) ? max_frame : RX_BUF_SIZE;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] r8169: clean up my printk uglyness
2010-04-01 17:30 ` Neil Horman
@ 2010-04-02 2:33 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2010-04-02 2:33 UTC (permalink / raw)
To: nhorman; +Cc: netdev, romieu, brandon
From: Neil Horman <nhorman@tuxdriver.com>
Date: Thu, 1 Apr 2010 13:30:07 -0400
> On Thu, Apr 01, 2010 at 10:53:56AM -0400, Neil Horman wrote:
>> Fix formatting on r8169 printk
>>
>> Brandon Philips noted that I had a spacing issue in my printk for the last r8169
>> patch that made it quite ugly. Fix that up and add the PFX macro to it as well
>> so it looks like the other r8169 printks
>>
>> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
>>
>>
> Grr, yes thanks, V2, fixing my idiocy :)
>
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Applied, thanks Neil.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-04-02 2:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-01 14:53 [PATCH] r8169: clean up my printk uglyness Neil Horman
2010-04-01 17:30 ` Neil Horman
2010-04-02 2:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).