* Re: [Bugme-new] [Bug 15683] New: XFRM IS NOT UPDATING ETH TYPE FIELD FOR INNER PACKET ON ETH [not found] <bug-15683-10286@https.bugzilla.kernel.org/> @ 2010-04-05 19:53 ` Andrew Morton 2010-04-05 19:55 ` Andrew Morton 1 sibling, 0 replies; 2+ messages in thread From: Andrew Morton @ 2010-04-05 19:53 UTC (permalink / raw) To: netdev; +Cc: bugzilla-daemon, bugme-daemon, David S. Miller, jamal (switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface). On Fri, 2 Apr 2010 18:17:07 GMT bugzilla-daemon@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=15683 > > Summary: XFRM IS NOT UPDATING ETH TYPE FIELD FOR INNER PACKET > ON ETH > Product: Networking > Version: 2.5 > Kernel Version: 2.6.28-2 > Platform: All > OS/Version: Linux > Tree: Mainline > Status: NEW > Severity: normal > Priority: P1 > Component: Other > AssignedTo: acme@ghostprotocols.net > ReportedBy: eduardo.panisset@gmail.com > Regression: No > > > Before doing this change wireshark was showing the inner packet as > "malformed" as it uses the ethernet's type field to classify the L3 > packets as IPv6, IPv4 and so on. > The problem is when the inner packet is reinserted into Linux stack > and the ethernet header keeps holding on its type field a value for > the protocol of outer packet. > > Below my correction on file net/xfrm/xfrm_input.c, function xfrm_prepare_input: > > ... > > skb->protocol = inner_mode->afinfo->eth_proto; // existing code > eth_hdr(skb)->h_proto = skb->protocol; // my change, adding this line > > ... > ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Bugme-new] [Bug 15683] New: XFRM IS NOT UPDATING ETH TYPE FIELD FOR INNER PACKET ON ETH [not found] <bug-15683-10286@https.bugzilla.kernel.org/> 2010-04-05 19:53 ` [Bugme-new] [Bug 15683] New: XFRM IS NOT UPDATING ETH TYPE FIELD FOR INNER PACKET ON ETH Andrew Morton @ 2010-04-05 19:55 ` Andrew Morton 1 sibling, 0 replies; 2+ messages in thread From: Andrew Morton @ 2010-04-05 19:55 UTC (permalink / raw) To: netdev Cc: bugzilla-daemon, bugme-daemon, David S. Miller, jamal, eduardo.panisset (resend - I forgot to cc Eduardo) (switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface). On Fri, 2 Apr 2010 18:17:07 GMT bugzilla-daemon@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=15683 > > Summary: XFRM IS NOT UPDATING ETH TYPE FIELD FOR INNER PACKET > ON ETH > Product: Networking > Version: 2.5 > Kernel Version: 2.6.28-2 > Platform: All > OS/Version: Linux > Tree: Mainline > Status: NEW > Severity: normal > Priority: P1 > Component: Other > AssignedTo: acme@ghostprotocols.net > ReportedBy: eduardo.panisset@gmail.com > Regression: No > > > Before doing this change wireshark was showing the inner packet as > "malformed" as it uses the ethernet's type field to classify the L3 > packets as IPv6, IPv4 and so on. > The problem is when the inner packet is reinserted into Linux stack > and the ethernet header keeps holding on its type field a value for > the protocol of outer packet. > > Below my correction on file net/xfrm/xfrm_input.c, function xfrm_prepare_input: > > ... > > skb->protocol = inner_mode->afinfo->eth_proto; // existing code > eth_hdr(skb)->h_proto = skb->protocol; // my change, adding this line > > ... > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-05 19:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <bug-15683-10286@https.bugzilla.kernel.org/>
2010-04-05 19:53 ` [Bugme-new] [Bug 15683] New: XFRM IS NOT UPDATING ETH TYPE FIELD FOR INNER PACKET ON ETH Andrew Morton
2010-04-05 19:55 ` Andrew Morton
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).