From: David Miller <davem@davemloft.net>
To: florian@openwrt.org
Cc: netdev@vger.kernel.org, darkadept@hispeed.ch
Subject: Re: [PATCH] r6040: fix r6040_multicast_list
Date: Wed, 07 Apr 2010 16:51:09 -0700 (PDT) [thread overview]
Message-ID: <20100407.165109.212914225.davem@davemloft.net> (raw)
In-Reply-To: <201004071318.48883.florian@openwrt.org>
From: Florian Fainelli <florian@openwrt.org>
Date: Wed, 7 Apr 2010 13:18:48 +0200
> As reported in <https://bugzilla.kernel.org/show_bug.cgi?id=15355>, r6040_
> multicast_list currently crashes. This is due a wrong maximum of multicast
> entries. This patch fixes the following issues with multicast:
>
> - number of maximum entries if off-by-one (4 instead of 3)
>
> - the writing of the hash table index is not necessary and leads to invalid
> values being written into the MCR1 register, so the MAC is simply put in a non
> coherent state
>
> - when we exceed the maximum number of mutlticast address, writing the
> broadcast address should be done in registers MID_1{L,M,H} instead of
> MID_O{L,M,H}, otherwise we would loose the adapter's MAC address
>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
Applied, thanks Florian.
prev parent reply other threads:[~2010-04-07 23:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-07 11:18 [PATCH] r6040: fix r6040_multicast_list Florian Fainelli
2010-04-07 23:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100407.165109.212914225.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=darkadept@hispeed.ch \
--cc=florian@openwrt.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).