* [PATCH 0/1]qlcnic: fix set mac addr
@ 2010-04-07 11:01 Amit Kumar Salecha
2010-04-07 11:01 ` [PATCH 1/1] qlcnic: " Amit Kumar Salecha
0 siblings, 1 reply; 3+ messages in thread
From: Amit Kumar Salecha @ 2010-04-07 11:01 UTC (permalink / raw)
To: davem; +Cc: netdev, ameen.rahman
Hi
Sending 1 important patch to fix bonding enviornment.
Mac addresses are not correctly communicated/set to fw, hence fw drops
packets as mac address doesn't match.
This fix need to be included in net-2.6 branch.
-Amit
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] qlcnic: fix set mac addr
2010-04-07 11:01 [PATCH 0/1]qlcnic: fix set mac addr Amit Kumar Salecha
@ 2010-04-07 11:01 ` Amit Kumar Salecha
2010-04-07 23:51 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Amit Kumar Salecha @ 2010-04-07 11:01 UTC (permalink / raw)
To: davem; +Cc: netdev, ameen.rahman
If interface is down, mac address request are not sent to fw
but it is getting add in driver mac list.
Driver mac list should be in sync with fw i.e addresses communicated
to fw.
Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>
---
drivers/net/qlcnic/qlcnic_hw.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/net/qlcnic/qlcnic_hw.c b/drivers/net/qlcnic/qlcnic_hw.c
index da00e16..b175313 100644
--- a/drivers/net/qlcnic/qlcnic_hw.c
+++ b/drivers/net/qlcnic/qlcnic_hw.c
@@ -430,6 +430,9 @@ void qlcnic_set_multi(struct net_device *netdev)
u8 bcast_addr[ETH_ALEN] = { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff };
u32 mode = VPORT_MISS_MODE_DROP;
+ if (adapter->is_up != QLCNIC_ADAPTER_UP_MAGIC)
+ return;
+
qlcnic_nic_add_mac(adapter, adapter->mac_addr);
qlcnic_nic_add_mac(adapter, bcast_addr);
--
1.6.0.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] qlcnic: fix set mac addr
2010-04-07 11:01 ` [PATCH 1/1] qlcnic: " Amit Kumar Salecha
@ 2010-04-07 23:51 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2010-04-07 23:51 UTC (permalink / raw)
To: amit.salecha; +Cc: netdev, ameen.rahman
From: Amit Kumar Salecha <amit.salecha@qlogic.com>
Date: Wed, 7 Apr 2010 04:01:54 -0700
> If interface is down, mac address request are not sent to fw
> but it is getting add in driver mac list.
> Driver mac list should be in sync with fw i.e addresses communicated
> to fw.
>
> Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-04-07 23:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-07 11:01 [PATCH 0/1]qlcnic: fix set mac addr Amit Kumar Salecha
2010-04-07 11:01 ` [PATCH 1/1] qlcnic: " Amit Kumar Salecha
2010-04-07 23:51 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).