From: David Miller <davem@davemloft.net>
To: sathyap@serverengines.com
Cc: fujita.tomonori@lab.ntt.co.jp, subbus@serverengines.com,
sarveshwarb@serverengines.com, ajitk@serverengines.com,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] benet: fix the misusage of zero dma address
Date: Wed, 07 Apr 2010 20:59:47 -0700 (PDT) [thread overview]
Message-ID: <20100407.205947.188334514.davem@davemloft.net> (raw)
In-Reply-To: <20100405082202.GB32671@serverengines.com>
From: Sathya Perla <sathyap@serverengines.com>
Date: Mon, 5 Apr 2010 13:52:02 +0530
> On 05/04/10 16:40 +0900, FUJITA Tomonori wrote:
>> > > + wrb->frag_len = 0;
>> > Why does wrb->frag_len need to be reset here?
>> > In the TX path, it is set to the proper value for data wrbs and zero
>> > for dummy and hdr wrbs.
>>
>> I guess that I misunderstood why unmap_tx_frag() checks a dma address.
>> The checking is necessary to avoid calling pci_unamp_* API for dummy
>> hdr wrbs?
> Yes.
>>
>> Anyway, if wrb->frag_len doesn't need to be reset here, the following
>> patch is ok?
> Yes. Thanks.
>
> Acked-by: Sathya Perla <sathyap@serverengines.com>
Applied to net-next-2.6
next prev parent reply other threads:[~2010-04-08 3:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-02 2:53 [PATCH 1/2] benet: use the dma state API instead of the pci equivalents FUJITA Tomonori
2010-04-02 2:53 ` [PATCH 2/2] benet: fix the misusage of zero dma address FUJITA Tomonori
2010-04-05 7:10 ` Sathya Perla
2010-04-05 7:40 ` FUJITA Tomonori
2010-04-05 8:22 ` Sathya Perla
2010-04-05 8:38 ` FUJITA Tomonori
2010-04-08 3:59 ` David Miller [this message]
2010-04-05 9:04 ` [PATCH 1/2] benet: use the dma state API instead of the pci equivalents Sathya Perla
2010-04-08 3:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100407.205947.188334514.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ajitk@serverengines.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=netdev@vger.kernel.org \
--cc=sarveshwarb@serverengines.com \
--cc=sathyap@serverengines.com \
--cc=subbus@serverengines.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).