netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] myri10ge: fix rx_pause in myri10ge_set_pauseparam
@ 2010-04-04 15:19 Brice Goglin
  2010-04-08  4:26 ` David Miller
  2010-04-08  5:21 ` Brice Goglin
  0 siblings, 2 replies; 4+ messages in thread
From: Brice Goglin @ 2010-04-04 15:19 UTC (permalink / raw)
  To: David S. Miller; +Cc: Linux Network Development list, Andrew J. Gallatin

Fix rx_pause in myri10ge_set_pauseparam().

Signed-off-by: Brice Goglin <brice@myri.com>

diff --git a/drivers/net/myri10ge/myri10ge.c
b/drivers/net/myri10ge/myri10ge.c
index e84dd3e..3cb7607 100644
--- a/drivers/net/myri10ge/myri10ge.c
+++ b/drivers/net/myri10ge/myri10ge.c
@@ -1689,7 +1689,7 @@ myri10ge_set_pauseparam(struct net_device *netdev,
     if (pause->tx_pause != mgp->pause)
         return myri10ge_change_pause(mgp, pause->tx_pause);
     if (pause->rx_pause != mgp->pause)
-        return myri10ge_change_pause(mgp, pause->tx_pause);
+        return myri10ge_change_pause(mgp, pause->rx_pause);
     if (pause->autoneg != 0)
         return -EINVAL;
     return 0;


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] myri10ge: fix rx_pause in myri10ge_set_pauseparam
  2010-04-04 15:19 [PATCH] myri10ge: fix rx_pause in myri10ge_set_pauseparam Brice Goglin
@ 2010-04-08  4:26 ` David Miller
  2010-04-08  5:21 ` Brice Goglin
  1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2010-04-08  4:26 UTC (permalink / raw)
  To: brice; +Cc: netdev, gallatin

From: Brice Goglin <brice@myri.com>
Date: Sun, 04 Apr 2010 17:19:00 +0200

> Fix rx_pause in myri10ge_set_pauseparam().
> 
> Signed-off-by: Brice Goglin <brice@myri.com>

Your patch is tab/whitespace damaged by your email client.

Fix this up and resubmit, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] myri10ge: fix rx_pause in myri10ge_set_pauseparam
  2010-04-04 15:19 [PATCH] myri10ge: fix rx_pause in myri10ge_set_pauseparam Brice Goglin
  2010-04-08  4:26 ` David Miller
@ 2010-04-08  5:21 ` Brice Goglin
  2010-04-08  5:23   ` David Miller
  1 sibling, 1 reply; 4+ messages in thread
From: Brice Goglin @ 2010-04-08  5:21 UTC (permalink / raw)
  To: David S. Miller; +Cc: Linux Network Development list

Fix rx_pause management in myri10ge_set_pauseparam().

Signed-off-by: Brice Goglin <brice@myri.com>

diff --git a/drivers/net/myri10ge/myri10ge.c b/drivers/net/myri10ge/myri10ge.c
index e84dd3e..3cb7607 100644
--- a/drivers/net/myri10ge/myri10ge.c
+++ b/drivers/net/myri10ge/myri10ge.c
@@ -1689,7 +1689,7 @@ myri10ge_set_pauseparam(struct net_device *netdev,
 	if (pause->tx_pause != mgp->pause)
 		return myri10ge_change_pause(mgp, pause->tx_pause);
 	if (pause->rx_pause != mgp->pause)
-		return myri10ge_change_pause(mgp, pause->tx_pause);
+		return myri10ge_change_pause(mgp, pause->rx_pause);
 	if (pause->autoneg != 0)
 		return -EINVAL;
 	return 0;



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] myri10ge: fix rx_pause in myri10ge_set_pauseparam
  2010-04-08  5:21 ` Brice Goglin
@ 2010-04-08  5:23   ` David Miller
  0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2010-04-08  5:23 UTC (permalink / raw)
  To: brice; +Cc: netdev

From: Brice Goglin <brice@myri.com>
Date: Thu, 08 Apr 2010 07:21:28 +0200

> Fix rx_pause management in myri10ge_set_pauseparam().
> 
> Signed-off-by: Brice Goglin <brice@myri.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-04-08  5:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-04 15:19 [PATCH] myri10ge: fix rx_pause in myri10ge_set_pauseparam Brice Goglin
2010-04-08  4:26 ` David Miller
2010-04-08  5:21 ` Brice Goglin
2010-04-08  5:23   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).