From: Randy Dunlap <randy.dunlap@oracle.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Stephen Rothwell <sfr@canb.auug.org.au>,
netdev <netdev@vger.kernel.org>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Tree for April 7 (net/core/dev_addr_lists)
Date: Wed, 7 Apr 2010 10:50:49 -0700 [thread overview]
Message-ID: <20100407105049.0f812b27.randy.dunlap@oracle.com> (raw)
In-Reply-To: <1270661889.8141.45.camel@edumazet-laptop>
On Wed, 07 Apr 2010 19:38:09 +0200 Eric Dumazet wrote:
> [PATCH net-next-2.6] net: include linux/proc_fs.h in dev_addr_lists.c
>
> As pointed by Randy Dunlap, we must include linux/proc_fs.h in
> net/core/dev_addr_lists.c, regardless of CONFIG_PROC_FS
>
> Reported-by: Randy Dunlap <randy.dunlap@oracle.com>,
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
Thanks, Eric.
> ---
> diff --git a/net/core/dev_addr_lists.c b/net/core/dev_addr_lists.c
> index 37d5975..508f9c1 100644
> --- a/net/core/dev_addr_lists.c
> +++ b/net/core/dev_addr_lists.c
> @@ -14,6 +14,7 @@
> #include <linux/netdevice.h>
> #include <linux/rtnetlink.h>
> #include <linux/list.h>
> +#include <linux/proc_fs.h>
>
> /*
> * General list handling functions
> @@ -667,7 +668,6 @@ void dev_mc_init(struct net_device *dev)
> EXPORT_SYMBOL(dev_mc_init);
>
> #ifdef CONFIG_PROC_FS
> -#include <linux/proc_fs.h>
> #include <linux/seq_file.h>
>
> static int dev_mc_seq_show(struct seq_file *seq, void *v)
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
---
~Randy
next prev parent reply other threads:[~2010-04-07 17:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100407174123.81b32310.sfr@canb.auug.org.au>
2010-04-07 16:58 ` linux-next: Tree for April 7 (net/core/dev_addr_lists) Randy Dunlap
2010-04-07 17:38 ` Eric Dumazet
2010-04-07 17:50 ` Randy Dunlap [this message]
2010-04-07 23:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100407105049.0f812b27.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).