From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: netdev@vger.kernel.org
Subject: Re: dhcp client packet sniffing...
Date: Thu, 08 Apr 2010 05:11:44 -0700 (PDT) [thread overview]
Message-ID: <20100408.051144.183699401.davem@davemloft.net> (raw)
In-Reply-To: <20100408114738.GA23329@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Thu, 8 Apr 2010 19:47:38 +0800
> Another approach is to use skb_share. At some point all protocols
> were designed to handle shared skbs.
>
> If we could tap into that then it would be an obvious way to
> eliminate the clone. To do this we'd need to audit all the
> protocols to ensure that they can still handle shared packets
> safely.
I don't even want to call down into the AF_PACKET code for
the case where the filter doesn't pass.
We have the socket pointer etc. already in dev_queue_xmit_nit(), so we
can easily do it.
next prev parent reply other threads:[~2010-04-08 12:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 10:50 dhcp client packet sniffing David Miller
2010-04-08 10:59 ` Neil Horman
2010-04-08 11:01 ` David Miller
2010-04-08 11:47 ` Herbert Xu
2010-04-08 12:11 ` David Miller [this message]
2010-04-08 12:30 ` Herbert Xu
2010-04-08 12:49 ` Patrick McHardy
2010-04-08 13:12 ` Herbert Xu
2010-04-08 13:23 ` Patrick McHardy
2010-04-08 14:27 ` Herbert Xu
2010-04-08 14:37 ` Maxime Bizon
2010-04-08 15:07 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100408.051144.183699401.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).