From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Timo Teräs" <timo.teras@iki.fi>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH] xfrm: Fix double dst_release() in xfrm_lookup() -EREMOTE case
Date: Thu, 8 Apr 2010 14:43:31 +0100 [thread overview]
Message-ID: <20100408134331.GC30647@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <4BBDCE8A.7040106@iki.fi>
On Thu, Apr 08, 2010 at 03:39:38PM +0300, Timo Teräs wrote:
> Mark Brown wrote:
> >I'm not sure if this is correct or not - there may a reference been
> >taken earlier in __xfrm_lookup() that's being dropped but I didn't spot
> >it.
> This is not correct.
So I was correct when I said that there might've been a reference taken
earlier :)
> This semantics is important because __xfrm_lookup() is also called
> from other places, that do other things when they get -EREMOTE.
Right, it was the fact that this was the only place doing the free that
made this unclear. Some comments might make this rather more obvious,
the fact that the release was added to __xfrm_lookup() as part of the
recent patch made it unclear if the release that was still there in
xfrm_lookup() was still needed or an oversight.
prev parent reply other threads:[~2010-04-08 13:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 12:29 [PATCH] xfrm: Fix double dst_release() in xfrm_lookup() -EREMOTE case Mark Brown
2010-04-08 12:39 ` Timo Teräs
2010-04-08 13:43 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100408134331.GC30647@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=timo.teras@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).