From mboxrd@z Thu Jan 1 00:00:00 1970 From: Octavian Purdila Subject: Re: [Patch 2/3] sysctl: add proc_do_large_bitmap Date: Fri, 9 Apr 2010 15:35:38 +0300 Message-ID: <201004091535.38714.opurdila@ixiacom.com> References: <20100409101442.5051.99812.sendpatchset@localhost.localdomain> <20100409101503.5051.3805.sendpatchset@localhost.localdomain> Mime-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Amerigo Wang , linux-kernel@vger.kernel.org, ebiederm@xmission.com, Eric Dumazet , netdev@vger.kernel.org, Neil Horman , David Miller To: Changli Gao Return-path: Received: from ixro-out-rtc.ixiacom.com ([92.87.192.98]:4266 "EHLO ixro-ex1.ixiacom.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751917Ab0DIMfl (ORCPT ); Fri, 9 Apr 2010 08:35:41 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Friday 09 April 2010 13:33:29 you wrote: > On Fri, Apr 9, 2010 at 6:11 PM, Amerigo Wang wrote: > > From: Octavian Purdila > > > > The new function can be used to read/write large bitmaps via /proc. A > > comma separated range format is used for compact output and input > > (e.g. 1,3-4,10-10). > > > > Writing into the file will first reset the bitmap then update it > > based on the given input. > > We have bitmap_scnprintf() and bitmap_parse_user(), why invent a new suite? > A decimal comma separated ranges seems the best option for this feature, and unfortunately both of the above functions only support hexadecimal and no ranges.