netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: netdev@vger.kernel.org
Cc: jeffrey.t.kirsher@intel.com, jesse.brandeburg@intel.com,
	bruce.w.allan@intel.com, alexander.h.duyck@intel.com,
	peter.p.waskiewicz.jr@intel.com, john.ronciak@intel.com
Subject: IGB handling of zero length checksumming?
Date: Sun, 11 Apr 2010 02:40:27 -0700 (PDT)	[thread overview]
Message-ID: <20100411.024027.120459168.davem@davemloft.net> (raw)


If the IGB is given a "skb->ip_summed === CHECKSUM_PARTIAL" packet and
the data area past the TCP header is of zero length, will it do the
right thing?

I'm asking because I made a change recently in net-2.6 that causes TCP
packets with no data (ACKs, etc.) to start using CHECKSUM_PARTIAL.

And a user with IGB interfaces on a system running net-2.6 is getting
failures connecting to SSH and stuff like that and it is known that
this TCP commit of mine is the culprit.  See:

http://marc.info/?l=linux-netdev&m=127097744616962&w=2

I'm very likely to just revert this change regardless of what the
problem is, and try to sort this out in net-next-2.6, but it'd be nice
to know if IGB indeed has a problem in this area and that's the true
cause of the issue.

Thanks!

             reply	other threads:[~2010-04-11  9:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-11  9:40 David Miller [this message]
2010-04-11 21:42 ` IGB handling of zero length checksumming? David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100411.024027.120459168.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alexander.h.duyck@intel.com \
    --cc=bruce.w.allan@intel.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=john.ronciak@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=peter.p.waskiewicz.jr@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).